Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: mash/quick_launch/quick_launch.cc

Issue 2505283003: Fix Ctrl-A then Ctrl-X infinite loop in quick_launch. (Closed)
Patch Set: Addressed feedback. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mash/quick_launch/quick_launch.cc
diff --git a/mash/quick_launch/quick_launch.cc b/mash/quick_launch/quick_launch.cc
index dd5bc32a621eacf98acb68c9400ff4dd1e65a357..ceae8d7ad6d55da69b478fc17b5329e91f902dc0 100644
--- a/mash/quick_launch/quick_launch.cc
+++ b/mash/quick_launch/quick_launch.cc
@@ -96,6 +96,9 @@ class QuickLaunchUI : public views::WidgetDelegateView,
if (suggestion_rejected_)
return;
+ if (new_contents.empty())
+ return;
+
// TODO(beng): it'd be nice if we persisted some history/scoring here.
for (const auto& name : app_names_) {
if (base::StartsWith(name, new_contents,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698