Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2505103002: Fix DCHECK failure in ObjectPainter::doCheckPaintOffset() for SVG objects (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK failure in ObjectPainter::doCheckPaintOffset() for SVG objects BUG=665259 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/9eaa9bf0791fc8ac4ddf4cf8aef7b93ace0b7306 Cr-Commit-Position: refs/heads/master@{#432652}

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/core/paint/ObjectPainter.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Xianzhu
https://codereview.chromium.org/2510513002/ breaks visual rects because we have duplicate offset in LayoutSVGText::visualRectInLocalSVGCoordinates() and paint offset. Need ...
4 years, 1 month ago (2016-11-16 19:51:26 UTC) #7
pdr.
On 2016/11/16 at 19:51:26, wangxianzhu wrote: > https://codereview.chromium.org/2510513002/ breaks visual rects because we have duplicate ...
4 years, 1 month ago (2016-11-16 21:14:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2505103002/20001
4 years, 1 month ago (2016-11-16 21:34:33 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 22:41:48 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 22:46:44 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9eaa9bf0791fc8ac4ddf4cf8aef7b93ace0b7306
Cr-Commit-Position: refs/heads/master@{#432652}

Powered by Google App Engine
This is Rietveld 408576698