Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: third_party/WebKit/Source/core/paint/ObjectPainter.cpp

Issue 2505103002: Fix DCHECK failure in ObjectPainter::doCheckPaintOffset() for SVG objects (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/ObjectPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/ObjectPainter.cpp b/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
index f56415b0083fa1e5dcddc4866f4ee3d0e1a31b9d..29664146d162b4275ef7c2a32bc532496bd38fbb 100644
--- a/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
@@ -699,6 +699,15 @@ void ObjectPainter::doCheckPaintOffset(const PaintInfo& paintInfo,
const LayoutPoint& paintOffset) {
DCHECK(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
+ // TODO(pdr,wangxianzhu): Refactor to avoid the special treatment for SVGText,
+ // SVGInline, SVGInlineText and SVGForeignObject.
+ if (m_layoutObject.isSVG() && !m_layoutObject.isSVGRoot() &&
+ !m_layoutObject.isSVGForeignObject()) {
+ if (!m_layoutObject.isSVGInline() && !m_layoutObject.isSVGInlineText())
+ DCHECK(paintOffset == LayoutPoint());
+ return;
+ }
+
// TODO(pdr): Let painter and paint property tree builder generate the same
// paint offset for LayoutScrollbarPart. crbug.com/664249.
if (m_layoutObject.isLayoutScrollbarPart())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698