Issue 2505063003: Support native app redirects to herb.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2505063003: Support native app redirects to herb. (Closed)

Created:
4 years, 1 month ago by Ted C

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Support native app redirects to herb. If in Herb mode, use the same intent handling logic as Chrome, which more aggressively intents out to external applications than a normal CCT. BUG=653254 Review-Url: https://codereview.chromium.org/2412613002 Cr-Commit-Position: refs/heads/master@{#424483} Committed: https://chromium.googlesource.com/chromium/src/+/2d21d33fdf5de895ffe8e4989f9975a57d9687a2

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -15 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java	View	3 chunks	+14 lines, -7 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabDelegateFactory.java	View	3 chunks	+12 lines, -5 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java	View	1 chunk	+7 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Ted C

4 years, 1 month ago (2016-11-16 21:14:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2d21d33fdf5de895ffe8e4989f9975a57d9687a2.