Revert of [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs.

Revert of [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs. (patchset #4 id:60001 of https://codereview.chromium.org/2497483002/ )

Reason for revert:
This was a speculative fix for perf regressions on Nexus 10 and ChromeOS. However, perf graphs after this landed show no improvement, so we should go back to the smaller, simpler code before.

Original issue's description:
> [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs.
> - Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods
> use only VFP registers to perform s-register moves.
>
> LOG=N
> BUG=v8:4124
TBR=bmeurer@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:4124
Committed: https://crrev.com/093267758ef4abe5b47688821b5ab5465eccb0d4
Cr-Commit-Position: refs/heads/master@{#41039}

[bbudge, 2016-11-16 14:32:02]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2016-11-16 14:32:03]

Created Revert of [Turbofan] CodeGenerator for ARM avoids moves from VFP to
general regs.

[commit-bot: I haz the power, 2016-11-16 14:32:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 15:00:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:36:28]

Description was changed from

==========
Revert of [Turbofan] CodeGenerator for ARM avoids moves from VFP to general
regs. (patchset #4 id:60001 of https://codereview.chromium.org/2497483002/ )

Reason for revert:
This was a speculative fix for perf regressions on Nexus 10 and ChromeOS.
However, perf graphs after this landed show no improvement, so we should go back
to the smaller, simpler code before.

Original issue's description:
> [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs.
> - Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods
> use only VFP registers to perform s-register moves.
> 
> LOG=N
> BUG=v8:4124

TBR=bmeurer@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:4124
==========

to

==========
Revert of [Turbofan] CodeGenerator for ARM avoids moves from VFP to general
regs. (patchset #4 id:60001 of https://codereview.chromium.org/2497483002/ )

Reason for revert:
This was a speculative fix for perf regressions on Nexus 10 and ChromeOS.
However, perf graphs after this landed show no improvement, so we should go back
to the smaller, simpler code before.

Original issue's description:
> [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs.
> - Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods
> use only VFP registers to perform s-register moves.
>
> LOG=N
> BUG=v8:4124

TBR=bmeurer@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:4124

Committed: https://crrev.com/093267758ef4abe5b47688821b5ab5465eccb0d4
Cr-Commit-Position: refs/heads/master@{#41039}
==========

[commit-bot: I haz the power, 2016-11-17 22:36:29]

Patchset 1 (id:??) landed as
https://crrev.com/093267758ef4abe5b47688821b5ab5465eccb0d4
Cr-Commit-Position: refs/heads/master@{#41039}

[Michael Hablich, 2016-11-23 16:18:20]

The original commit is on the 5.6 branch but this revert is not. We probably
should merge the revert to 5.6, right?

[Michael Hablich, 2016-11-23 16:18:41]

Description was changed from

==========
Revert of [Turbofan] CodeGenerator for ARM avoids moves from VFP to general
regs. (patchset #4 id:60001 of https://codereview.chromium.org/2497483002/ )

Reason for revert:
This was a speculative fix for perf regressions on Nexus 10 and ChromeOS.
However, perf graphs after this landed show no improvement, so we should go back
to the smaller, simpler code before.

Original issue's description:
> [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs.
> - Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods
> use only VFP registers to perform s-register moves.
>
> LOG=N
> BUG=v8:4124

TBR=bmeurer@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:4124

Committed: https://crrev.com/093267758ef4abe5b47688821b5ab5465eccb0d4
Cr-Commit-Position: refs/heads/master@{#41039}
==========

to

==========
Revert of [Turbofan] CodeGenerator for ARM avoids moves from VFP to general
regs. (patchset #4 id:60001 of https://codereview.chromium.org/2497483002/ )

Reason for revert:
This was a speculative fix for perf regressions on Nexus 10 and ChromeOS.
However, perf graphs after this landed show no improvement, so we should go back
to the smaller, simpler code before.

Original issue's description:
> [Turbofan] CodeGenerator for ARM avoids moves from VFP to general regs.
> - Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods
> use only VFP registers to perform s-register moves.
>
> LOG=N
> BUG=v8:4124

TBR=bmeurer@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:4124

Committed: https://crrev.com/093267758ef4abe5b47688821b5ab5465eccb0d4
Cr-Commit-Position: refs/heads/master@{#41039}
==========

[bbudge, 2016-11-23 16:21:01]

On 2016/11/23 16:18:20, Hablich wrote:
> The original commit is on the 5.6 branch but this revert is not. We probably
> should merge the revert to 5.6, right?

Yes, there's no upside and some chance it could cause a regression.