Refactored loading of applications / extensions icons.

chrome/browser/extensions/api/developer_private/developer_private_api.h

Index: chrome/browser/extensions/api/developer_private/developer_private_api.h
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.h b/chrome/browser/extensions/api/developer_private/developer_private_api.h
index ac5dc5c5ca828a5ac6bd3d232c11cb3861377b58..0847da699ce609c6205afd8623aa1435def85f80 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.h
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.h
@@ -133,6 +133,8 @@ class DeveloperPrivateGetItemsInfoFunction : public AsyncExtensionFunction {
   DECLARE_EXTENSION_FUNCTION("developerPrivate.getItemsInfo",
                              DEVELOPERPRIVATE_GETITEMSINFO)
 
+  DeveloperPrivateGetItemsInfoFunction();
+
  protected:
   virtual ~DeveloperPrivateGetItemsInfoFunction();
 
@@ -140,15 +142,17 @@ class DeveloperPrivateGetItemsInfoFunction : public AsyncExtensionFunction {
   virtual bool RunImpl() OVERRIDE;
 
  private:
+  // List of extensions/apps items to return.

[Finnur, 2013/09/30 15:11:21]

This serves more of a purpose than returning data. It also keeps track of the
data needed to determine which icon(s) to load, no?

[dvh-g, 2013/10/01 04:19:26]

Actually, this class will return the list of extensions/apps: the information
related to a specific app/extension, including its icon. Do you think we need
more comment?

[Finnur, 2013/10/01 11:14:15]

Yes. My point was that you use this data structure not just to return data but
also to keep track of work that needs to be done (with the help of
icon_to_load_).

[dvh, 2013/10/02 05:15:08]

Done.

+  ItemInfoList item_list_;
+
+  // Index of the extension/app in |item_list_| for which we need to load the
+  // icon.
+  unsigned int icon_to_load_;

[Finnur, 2013/09/30 15:11:21]

Style guide says don't use unsigned types.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Intege...

[dvh-g, 2013/10/01 04:19:26]

Done.

 
   scoped_ptr<developer::ItemInfo> CreateItemInfo(
       const extensions::Extension& item,
       bool item_is_enabled);
 
-  void GetIconsOnFileThread(
-      ItemInfoList item_list,
-      std::map<std::string, ExtensionResource> itemIdToIconResourceMap);
-
   // Helper that lists the current inspectable html pages for the extension.
   void GetInspectablePagesForExtensionProcess(
       const Extension* extension,
@@ -169,6 +173,13 @@ class DeveloperPrivateGetItemsInfoFunction : public AsyncExtensionFunction {
       int render_view_id,
       bool incognito,
       bool generated_background_page);
+
+  // Request icon the the extension/app at the index |icon_to_load_| in

[Finnur, 2013/09/30 15:11:21]

A question from the quick-and-dirty-haiku-dude:

When code this fall lands,
is request icon the the
true proper English?

;)

[dvh-g, 2013/10/01 04:19:26]

I'll try to. Fixing it.

+  // |item_list_|.
+  void RequestNextIcon();
+
+  // Called the icon requested byRequestNextIcon() has been loaded.

[Finnur, 2013/09/30 15:11:21]

nit: This also needs a bit of rewording. Suggest: Called when each icon, has
loaded by RequestNextIcon(). |url| is the data url containing the icon.

[dvh-g, 2013/10/01 04:19:26]

Done.

+  void LoadIconFinished(const GURL& url);
 };
 
 class DeveloperPrivateInspectFunction : public SyncExtensionFunction {