Refactored loading of applications / extensions icons.

chrome/browser/extensions/api/developer_private/developer_private_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_
 
 #include "base/platform_file.h"
 #include "chrome/browser/extensions/api/developer_private/entry_picker.h"
 #include "chrome/browser/extensions/api/file_system/file_system_api.h"
@@ skipping 115 matching lines @@
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 };
 
 class DeveloperPrivateGetItemsInfoFunction : public AsyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("developerPrivate.getItemsInfo",
                              DEVELOPERPRIVATE_GETITEMSINFO)
 
+  DeveloperPrivateGetItemsInfoFunction();
+
  protected:
   virtual ~DeveloperPrivateGetItemsInfoFunction();
 
   // ExtensionFunction:
   virtual bool RunImpl() OVERRIDE;
 
  private:
+  // List of extensions/apps items to return.

[Finnur, 2013/09/30 15:11:21]

This serves more of a purpose than returning data. It also keeps track of the
data needed to determine which icon(s) to load, no?

[dvh-g, 2013/10/01 04:19:26]

Actually, this class will return the list of extensions/apps: the information
related to a specific app/extension, including its icon. Do you think we need
more comment?

[Finnur, 2013/10/01 11:14:15]

Yes. My point was that you use this data structure not just to return data but
also to keep track of work that needs to be done (with the help of
icon_to_load_).

[dvh, 2013/10/02 05:15:08]

Done.

+  ItemInfoList item_list_;
+
+  // Index of the extension/app in |item_list_| for which we need to load the
+  // icon.
+  unsigned int icon_to_load_;

[Finnur, 2013/09/30 15:11:21]

Style guide says don't use unsigned types.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Intege...

[dvh-g, 2013/10/01 04:19:26]

Done.

 
   scoped_ptr<developer::ItemInfo> CreateItemInfo(
       const extensions::Extension& item,
       bool item_is_enabled);
 
-  void GetIconsOnFileThread(
-      ItemInfoList item_list,
-      std::map<std::string, ExtensionResource> itemIdToIconResourceMap);
-
   // Helper that lists the current inspectable html pages for the extension.
   void GetInspectablePagesForExtensionProcess(
       const Extension* extension,
       const std::set<content::RenderViewHost*>& views,
       ItemInspectViewList* result);
 
   ItemInspectViewList GetInspectablePagesForExtension(
       const extensions::Extension* extension,
       bool extension_is_enabled);
 
   void GetShellWindowPagesForExtensionProfile(
       const extensions::Extension* extension,
       ItemInspectViewList* result);
 
   linked_ptr<developer::ItemInspectView> constructInspectView(
       const GURL& url,
       int render_process_id,
       int render_view_id,
       bool incognito,
       bool generated_background_page);
+
+  // Request icon the the extension/app at the index |icon_to_load_| in

[Finnur, 2013/09/30 15:11:21]

A question from the quick-and-dirty-haiku-dude:

When code this fall lands,
is request icon the the
true proper English?

;)

[dvh-g, 2013/10/01 04:19:26]

I'll try to. Fixing it.

+  // |item_list_|.
+  void RequestNextIcon();
+
+  // Called the icon requested byRequestNextIcon() has been loaded.

[Finnur, 2013/09/30 15:11:21]

nit: This also needs a bit of rewording. Suggest: Called when each icon, has
loaded by RequestNextIcon(). |url| is the data url containing the icon.

[dvh-g, 2013/10/01 04:19:26]

Done.

+  void LoadIconFinished(const GURL& url);
 };
 
 class DeveloperPrivateInspectFunction : public SyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("developerPrivate.inspect",
                              DEVELOPERPRIVATE_INSPECT)
 
  protected:
   virtual ~DeveloperPrivateInspectFunction();
 
@@ skipping 241 matching lines @@
 
    void GetUnpackedExtension(const base::FilePath& path,
                              const ExtensionSet* extensions);
 };
 
 }  // namespace api
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_DEVELOPER_PRIVATE_DEVELOPER_PRIVATE_API_H_