[NTP Snippets] Track impression only when 2/3 of a card is visible (rather than 1/3)

[NTP Snippets] Track impression only when 2/3 of a card is visible (rather than 1/3)

This fixes the problem of immediately recording an impression due to the "increased visibility" experiment.

BUG=664539
Committed: https://crrev.com/053a4b8feac3a0565e078b8c29d3472c0ea4078c
Cr-Commit-Position: refs/heads/master@{#432480}

[Marc Treib, 2016-11-16 12:23:16]

treib@chromium.org changed reviewers:
+ peconn@chromium.org

[Marc Treib, 2016-11-16 12:23:17]

So here's the quick fix I mentioned on the bug - WDYT?

[Marc Treib, 2016-11-16 12:23:23]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 12:23:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[PEConn, 2016-11-16 13:45:07]

On 2016/11/16 12:23:17, Marc Treib wrote:
> So here's the quick fix I mentioned on the bug - WDYT?

LGTM assuming you've tested that this works when the animation runs.

[Marc Treib, 2016-11-16 13:57:54]

On 2016/11/16 13:45:07, PEConn wrote:
> On 2016/11/16 12:23:17, Marc Treib wrote:
> > So here's the quick fix I mentioned on the bug - WDYT?
> 
> LGTM assuming you've tested that this works when the animation runs.

Yup, I've tested it - as far as I can tell, the animation never pulls 2/3 of the
card onto the screen. (It's hard to be 100% sure, with different card sizes
etc...)

[Marc Treib, 2016-11-16 13:57:58]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 13:58:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2016-11-16 14:21:50]

The CQ bit was unchecked by treib@chromium.org

[Marc Treib, 2016-11-16 14:21:51]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-11-16 14:22:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 14:34:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-16 14:38:22]

Description was changed from

==========
[NTP Snippets] Track impression only when 2/3 of a card is visible (rather than
1/3)

This fixes the problem of immediately recording an impression due to the
"increased visibility" experiment.

BUG=664539
==========

to

==========
[NTP Snippets] Track impression only when 2/3 of a card is visible (rather than
1/3)

This fixes the problem of immediately recording an impression due to the
"increased visibility" experiment.

BUG=664539

Committed: https://crrev.com/053a4b8feac3a0565e078b8c29d3472c0ea4078c
Cr-Commit-Position: refs/heads/master@{#432480}
==========

[commit-bot: I haz the power, 2016-11-16 14:38:22]

Patchset 3 (id:??) landed as
https://crrev.com/053a4b8feac3a0565e078b8c29d3472c0ea4078c
Cr-Commit-Position: refs/heads/master@{#432480}