Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8234)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ImpressionTracker.java

Issue 2504963002: [NTP Snippets] Track impression only when 2/3 of a card is visible (rather than 1/3) (Closed)
Patch Set: update comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ImpressionTracker.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ImpressionTracker.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ImpressionTracker.java
index 9fefe6faa696616de5c7826003eb9633e8e83bd8..11f6cb037e79c31e0ffcbca2be49d62c3a33431e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ImpressionTracker.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ImpressionTracker.java
@@ -17,7 +17,7 @@ import android.view.ViewTreeObserver;
public class ImpressionTracker
implements ViewTreeObserver.OnPreDrawListener, View.OnAttachStateChangeListener {
/**
- * The Listener will be called back on each impression. Whenever at least 1/3 of the view's
+ * The Listener will be called back on each impression. Whenever at least 2/3 of the view's
* height is visible, that counts as an impression. Note that this will get called often while
* the view is visible; it's the implementer's responsibility to count only one impression or
* reset the {@link ImpressionTracker}.
@@ -92,8 +92,8 @@ public class ImpressionTracker
if (parent != null) {
Rect rect = new Rect(0, 0, mView.getWidth(), mView.getHeight());
parent.getChildVisibleRect(mView, rect, null);
- // Track impression if at least one third of the view is visible.
- if (rect.height() >= mView.getHeight() / 3) {
+ // Track impression if at least 2/3 of the view is visible.
+ if (rect.height() >= 2 * mView.getHeight() / 3) {
mTriggered = true;
mListener.onImpression();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698