Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2504913002: Revert of [refactoring] Split CodeAssemblerState out of CodeAssembler (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [refactoring] Split CodeAssemblerState out of CodeAssembler (patchset #8 id:140001 of https://codereview.chromium.org/2498073002/ ) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared doesn't want to compile. Missing export annotation? Original issue's description: > [refactoring] Split CodeAssemblerState out of CodeAssembler > > This is in preparation for introducing more specialized > CodeStubAssembler subclasses. The state object can be handed > around, while the Assembler instances are temporary-scoped. > > BUG=v8:5628 TBR=ishell@chromium.org,mstarzinger@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5628 Committed: https://crrev.com/41a0626787003e4c3c52545fb7e4767bb9313faa Cr-Commit-Position: refs/heads/master@{#41018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4765 lines, -5037 lines) Patch
M src/builtins/builtins.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/builtins/builtins.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M src/builtins/builtins-array.cc View 7 chunks +1002 lines, -1000 lines 0 comments Download
M src/builtins/builtins-boolean.cc View 1 chunk +11 lines, -15 lines 0 comments Download
M src/builtins/builtins-conversion.cc View 2 chunks +219 lines, -233 lines 0 comments Download
M src/builtins/builtins-date.cc View 2 chunks +73 lines, -106 lines 0 comments Download
M src/builtins/builtins-function.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M src/builtins/builtins-generator.cc View 1 chunk +6 lines, -12 lines 0 comments Download
M src/builtins/builtins-global.cc View 1 chunk +64 lines, -65 lines 0 comments Download
M src/builtins/builtins-handler.cc View 4 chunks +73 lines, -64 lines 0 comments Download
M src/builtins/builtins-internal.cc View 1 chunk +44 lines, -48 lines 0 comments Download
M src/builtins/builtins-iterator.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/builtins/builtins-math.cc View 5 chunks +266 lines, -294 lines 0 comments Download
M src/builtins/builtins-number.cc View 4 chunks +997 lines, -1013 lines 0 comments Download
M src/builtins/builtins-object.cc View 4 chunks +241 lines, -250 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 9 chunks +205 lines, -226 lines 0 comments Download
M src/builtins/builtins-sharedarraybuffer.cc View 6 chunks +85 lines, -87 lines 0 comments Download
M src/builtins/builtins-string.cc View 8 chunks +297 lines, -320 lines 0 comments Download
M src/builtins/builtins-symbol.cc View 1 chunk +18 lines, -23 lines 0 comments Download
M src/builtins/builtins-typedarray.cc View 2 chunks +67 lines, -68 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +11 lines, -2 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/code-stubs.h View 18 chunks +111 lines, -45 lines 0 comments Download
M src/code-stubs.cc View 17 chunks +551 lines, -647 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/code-assembler.h View 6 chunks +21 lines, -45 lines 0 comments Download
M src/compiler/code-assembler.cc View 34 chunks +125 lines, -137 lines 0 comments Download
M src/fast-accessor-assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/fast-accessor-assembler.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/ic/keyed-store-generic.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/ic/keyed-store-generic.cc View 3 chunks +10 lines, -20 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M test/cctest/compiler/code-assembler-tester.h View 2 chunks +32 lines, -25 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/function-tester.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/compiler/test-code-assembler.cc View 20 chunks +63 lines, -64 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 52 chunks +91 lines, -116 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.h View 3 chunks +3 lines, -11 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 20 chunks +19 lines, -44 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of [refactoring] Split CodeAssemblerState out of CodeAssembler
4 years, 1 month ago (2016-11-16 07:53:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504913002/1
4 years, 1 month ago (2016-11-16 07:53:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 07:53:57 UTC) #4
Jakob Kummerow
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2502293002/ by jkummerow@chromium.org. ...
4 years, 1 month ago (2016-11-16 09:35:04 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:35:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41a0626787003e4c3c52545fb7e4767bb9313faa
Cr-Commit-Position: refs/heads/master@{#41018}

Powered by Google App Engine
This is Rietveld 408576698