Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Side by Side Diff: src/builtins/builtins.h

Issue 2504913002: Revert of [refactoring] Split CodeAssemblerState out of CodeAssembler (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins/builtins.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_BUILTINS_BUILTINS_H_ 5 #ifndef V8_BUILTINS_BUILTINS_H_
6 #define V8_BUILTINS_BUILTINS_H_ 6 #define V8_BUILTINS_BUILTINS_H_
7 7
8 #include "src/base/flags.h" 8 #include "src/base/flags.h"
9 #include "src/handles.h" 9 #include "src/handles.h"
10 10
(...skipping 698 matching lines...) Expand 10 before | Expand all | Expand 10 after
709 709
710 #define BUILTIN_LIST_A(V) \ 710 #define BUILTIN_LIST_A(V) \
711 BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \ 711 BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \
712 V, V, V) 712 V, V, V)
713 713
714 #define BUILTIN_LIST_DBG(V) \ 714 #define BUILTIN_LIST_DBG(V) \
715 BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \ 715 BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \
716 IGNORE_BUILTIN, IGNORE_BUILTIN, V) 716 IGNORE_BUILTIN, IGNORE_BUILTIN, V)
717 717
718 // Forward declarations. 718 // Forward declarations.
719 class CodeStubAssembler;
719 class ObjectVisitor; 720 class ObjectVisitor;
720 namespace compiler {
721 class CodeAssemblerState;
722 }
723 721
724 class Builtins { 722 class Builtins {
725 public: 723 public:
726 ~Builtins(); 724 ~Builtins();
727 725
728 // Generate all builtin code objects. Should be called once during 726 // Generate all builtin code objects. Should be called once during
729 // isolate initialization. 727 // isolate initialization.
730 void SetUp(Isolate* isolate, bool create_heap_objects); 728 void SetUp(Isolate* isolate, bool create_heap_objects);
731 void TearDown(); 729 void TearDown();
732 730
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
811 static void Generate_Call(MacroAssembler* masm, ConvertReceiverMode mode, 809 static void Generate_Call(MacroAssembler* masm, ConvertReceiverMode mode,
812 TailCallMode tail_call_mode); 810 TailCallMode tail_call_mode);
813 811
814 static void Generate_InterpreterPushArgsAndCallImpl( 812 static void Generate_InterpreterPushArgsAndCallImpl(
815 MacroAssembler* masm, TailCallMode tail_call_mode, 813 MacroAssembler* masm, TailCallMode tail_call_mode,
816 CallableType function_type); 814 CallableType function_type);
817 815
818 static void Generate_InterpreterPushArgsAndConstructImpl( 816 static void Generate_InterpreterPushArgsAndConstructImpl(
819 MacroAssembler* masm, CallableType function_type); 817 MacroAssembler* masm, CallableType function_type);
820 818
819 static void Generate_DatePrototype_GetField(CodeStubAssembler* masm,
820 int field_index);
821
821 enum class MathMaxMinKind { kMax, kMin }; 822 enum class MathMaxMinKind { kMax, kMin };
822 static void Generate_MathMaxMin(MacroAssembler* masm, MathMaxMinKind kind); 823 static void Generate_MathMaxMin(MacroAssembler* masm, MathMaxMinKind kind);
823 824
824 #define DECLARE_ASM(Name, ...) \ 825 #define DECLARE_ASM(Name, ...) \
825 static void Generate_##Name(MacroAssembler* masm); 826 static void Generate_##Name(MacroAssembler* masm);
826 #define DECLARE_TF(Name, ...) \ 827 #define DECLARE_TF(Name, ...) \
827 static void Generate_##Name(compiler::CodeAssemblerState* state); 828 static void Generate_##Name(CodeStubAssembler* csasm);
828 829
829 BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, DECLARE_TF, DECLARE_TF, 830 BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, DECLARE_TF, DECLARE_TF,
830 DECLARE_ASM, DECLARE_ASM, DECLARE_ASM) 831 DECLARE_ASM, DECLARE_ASM, DECLARE_ASM)
831 832
832 #undef DECLARE_ASM 833 #undef DECLARE_ASM
833 #undef DECLARE_TF 834 #undef DECLARE_TF
834 835
835 // Note: These are always Code objects, but to conform with 836 // Note: These are always Code objects, but to conform with
836 // IterateBuiltins() above which assumes Object**'s for the callback 837 // IterateBuiltins() above which assumes Object**'s for the callback
837 // function f, we use an Object* array here. 838 // function f, we use an Object* array here.
838 Object* builtins_[builtin_count]; 839 Object* builtins_[builtin_count];
839 bool initialized_; 840 bool initialized_;
840 841
841 friend class Isolate; 842 friend class Isolate;
842 843
843 DISALLOW_COPY_AND_ASSIGN(Builtins); 844 DISALLOW_COPY_AND_ASSIGN(Builtins);
844 }; 845 };
845 846
846 } // namespace internal 847 } // namespace internal
847 } // namespace v8 848 } // namespace v8
848 849
849 #endif // V8_BUILTINS_BUILTINS_H_ 850 #endif // V8_BUILTINS_BUILTINS_H_
OLDNEW
« no previous file with comments | « no previous file | src/builtins/builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698