Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2504843002: Prevent WebVR from reprojecting with invalid poses (Closed)

Created:
4 years, 1 month ago by bajones
Modified:
4 years, 1 month ago
Reviewers:
klausw
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent WebVR from reprojecting with invalid poses BUG=389343 Committed: https://crrev.com/d5bfade6398eca2614c30fd3ec9aea58f989baee Cr-Commit-Position: refs/heads/master@{#432412}

Patch Set 1 #

Patch Set 2 : Addressed Klaus' feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/android/vr_shell/vr_shell.cc View 1 1 chunk +10 lines, -1 line 0 comments Download
M device/vr/android/gvr/gvr_device.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
bajones
Simple fix, but makes a BIG difference in how stable the reprojected contents are!
4 years, 1 month ago (2016-11-16 01:42:25 UTC) #2
klausw
On 2016/11/16 01:42:25, bajones wrote: > Simple fix, but makes a BIG difference in how ...
4 years, 1 month ago (2016-11-16 03:06:34 UTC) #3
bajones
On 2016/11/16 03:06:34, klausw wrote: > On 2016/11/16 01:42:25, bajones wrote: > > Simple fix, ...
4 years, 1 month ago (2016-11-16 04:59:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504843002/20001
4 years, 1 month ago (2016-11-16 05:00:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 06:49:51 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 06:52:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5bfade6398eca2614c30fd3ec9aea58f989baee
Cr-Commit-Position: refs/heads/master@{#432412}

Powered by Google App Engine
This is Rietveld 408576698