device/vr/android/gvr/gvr_device.h - Issue 2504843002: Prevent WebVR from reprojecting with invalid poses

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/vr/android/gvr/gvr_device.h

Issue 2504843002: Prevent WebVR from reprojecting with invalid poses (Closed)

Patch Set: Addressed Klaus' feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/android/vr_shell/vr_shell.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef DEVICE_VR_ANDROID_GVR_DEVICE_H	5 #ifndef DEVICE_VR_ANDROID_GVR_DEVICE_H

6 #define DEVICE_VR_ANDROID_GVR_DEVICE_H	6 #define DEVICE_VR_ANDROID_GVR_DEVICE_H

7	7

8 #include "base/macros.h"	8 #include "base/macros.h"

9 #include "base/memory/weak_ptr.h"	9 #include "base/memory/weak_ptr.h"

10 #include "device/vr/vr_device.h"	10 #include "device/vr/vr_device.h"

(...skipping 26 matching lines...) Expand all Loading...
37 mojom::VRLayerBoundsPtr right_bounds) override;	37 mojom::VRLayerBoundsPtr right_bounds) override;

38	38

39 void SetDelegate(const base::WeakPtr<GvrDelegate>& delegate);	39 void SetDelegate(const base::WeakPtr<GvrDelegate>& delegate);

40	40

41 private:	41 private:

42 gvr::GvrApi* GetGvrApi();	42 gvr::GvrApi* GetGvrApi();

43	43

44 base::WeakPtr<GvrDelegate> delegate_;	44 base::WeakPtr<GvrDelegate> delegate_;

45 GvrDeviceProvider* gvr_provider_;	45 GvrDeviceProvider* gvr_provider_;

46 bool secure_origin_ = false;	46 bool secure_origin_ = false;

47 uint32_t pose_index_ = 0;	47 uint32_t pose_index_ = 1;

48	48

49 DISALLOW_COPY_AND_ASSIGN(GvrDevice);	49 DISALLOW_COPY_AND_ASSIGN(GvrDevice);

50 };	50 };

51	51

52 } // namespace device	52 } // namespace device

53	53

54 #endif // DEVICE_VR_ANDROID_GVR_DEVICE_H	54 #endif // DEVICE_VR_ANDROID_GVR_DEVICE_H

OLD	NEW