Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2504803002: Disable spammy logging in InterfaceRegistry affecting too many people. (Closed)

Created:
4 years, 1 month ago by miu
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable spammy logging in InterfaceRegistry affecting too many people. A recent change added error logging to InterfaceRegistry which has, at some point since then, become suddenly spammy. This change sets the log level to VLOG(1) since the cause of the problem is well-understood, but the solution is not as of yet; and the spammy logging is affecting all non-Chrome embedders (including tests running on bots, or locally by devs). Change that added the error logging: https://codereview.chromium.org/2457493004 BUG=664595 R=rockot@chromium.org Committed: https://crrev.com/face478e9879692bae410d450acceaddf6106532 Cr-Commit-Position: refs/heads/master@{#432344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M services/service_manager/public/cpp/lib/interface_registry.cc View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
miu
rockot: PTAL.
4 years, 1 month ago (2016-11-15 23:14:37 UTC) #1
Ken Rockot(use gerrit already)
I'm not crazy about this, because it seems to me the right thing to do ...
4 years, 1 month ago (2016-11-15 23:17:53 UTC) #2
miu
On 2016/11/15 23:17:53, Ken Rockot wrote: > I'm not crazy about this, because it seems ...
4 years, 1 month ago (2016-11-15 23:23:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504803002/1
4 years, 1 month ago (2016-11-15 23:24:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261344)
4 years, 1 month ago (2016-11-15 23:48:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504803002/1
4 years, 1 month ago (2016-11-16 00:42:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 01:36:05 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 01:43:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/face478e9879692bae410d450acceaddf6106532
Cr-Commit-Position: refs/heads/master@{#432344}

Powered by Google App Engine
This is Rietveld 408576698