Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: services/service_manager/public/cpp/lib/interface_registry.cc

Issue 2504803002: Disable spammy logging in InterfaceRegistry affecting too many people. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/service_manager/public/cpp/lib/interface_registry.cc
diff --git a/services/service_manager/public/cpp/lib/interface_registry.cc b/services/service_manager/public/cpp/lib/interface_registry.cc
index 039b86679c66b6d5894f2a25aeb618cb33b9c051..e912d3ee63427f84d9b8bbb89718005cf8580c5b 100644
--- a/services/service_manager/public/cpp/lib/interface_registry.cc
+++ b/services/service_manager/public/cpp/lib/interface_registry.cc
@@ -6,6 +6,7 @@
#include <sstream>
+#include "base/logging.h"
#include "mojo/public/cpp/bindings/message.h"
#include "services/service_manager/public/cpp/connection.h"
@@ -201,13 +202,17 @@ void InterfaceRegistry::GetInterface(const std::string& interface_name,
} else if (!default_binder_.is_null()) {
default_binder_.Run(interface_name, std::move(handle));
} else {
- std::stringstream ss;
- ss << "Failed to locate a binder for interface: " << interface_name
- << " requested by: " << remote_identity_.name() << " exposed by: "
- << local_identity_.name() << " via InterfaceProviderSpec \"" << name_
- << "\".";
- Serialize(&ss);
- LOG(ERROR) << ss.str();
+ // TODO(miu): Disable spammy logging until client --> embedder service
+ // issue is fixed. https://crbug.com/664595
+ if (VLOG_IS_ON(1)) {
+ std::stringstream ss;
+ ss << "Failed to locate a binder for interface: " << interface_name
+ << " requested by: " << remote_identity_.name() << " exposed by: "
+ << local_identity_.name() << " via InterfaceProviderSpec \"" << name_
+ << "\".";
+ Serialize(&ss);
+ VLOG(1) << ss.str();
+ }
}
} else {
std::stringstream ss;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698