Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2504733002: Fix _wrapDartFunction to call the JS set method directly. At one point this code was previously sur… (Closed)

Created:
4 years, 1 month ago by Jacob
Modified:
4 years, 1 month ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix _wrapDartFunction to call the JS set method directly. At one point this code was previously surprisingly generating a direct call to set instead of a call to dsetindex. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/fb467ef68afb23de7decfbdfad9c217aa6f002fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/js/dart2js/js_dart2js.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
Strange the original code ever generated a call to set. The JS WeakMap we are ...
4 years, 1 month ago (2016-11-15 20:43:30 UTC) #2
vsm
lgtm
4 years, 1 month ago (2016-11-15 20:48:46 UTC) #3
Jacob
4 years, 1 month ago (2016-11-15 20:52:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fb467ef68afb23de7decfbdfad9c217aa6f002fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698