pkg/dev_compiler/lib/js/es6/dart_sdk.js - Issue 2504733002: Fix _wrapDartFunction to call the JS set method directly. At one point this code was previously sur…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/lib/js/es6/dart_sdk.js

Issue 2504733002: Fix _wrapDartFunction to call the JS set method directly. At one point this code was previously sur… (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/lib/js/es6/dart_sdk.js

diff --git a/pkg/dev_compiler/lib/js/es6/dart_sdk.js b/pkg/dev_compiler/lib/js/es6/dart_sdk.js

index a0eb5ef14ef97cf7b4e0684cbc70ee2c5e855085..c16638f3fe3ac6dc4a1aa1d7a168dedc8b9a6ba1 100644

--- a/pkg/dev_compiler/lib/js/es6/dart_sdk.js

+++ b/pkg/dev_compiler/lib/js/es6/dart_sdk.js

@@ -36888,7 +36888,7 @@ js._wrapDartFunction = function(f) {

let args = Array.prototype.map.call(arguments, js._convertToDart);

return js._convertToJS(f(...args));

};

- dart.dsetindex(js._dartProxies, wrapper, f);

+ js._dartProxies.set(wrapper, f);

return wrapper;

};

dart.fn(js._wrapDartFunction, dynamicTodynamic());