Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2504693002: Mark lazily-patched native calls correctly as patchable. (Closed)

Created:
4 years, 1 month ago by kustermann
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark lazily-patched native calls correctly as patchable. Lazily linked native entries patch two entries: target native *and* the stub that is used for call. It only works because we don't ever have two native nodes inside a single function. However it makes sense to always correctly generate patchable calls as patchable. R=fschneider@google.com, vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/a4dbbaae1045f43a65011584d2746985d79e717b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -10 lines) Patch
M runtime/vm/flow_graph_compiler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kustermann
4 years, 1 month ago (2016-11-15 17:44:11 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 1 month ago (2016-11-15 17:55:56 UTC) #3
Florian Schneider
Please provide a CL description with the reason behind this.
4 years, 1 month ago (2016-11-15 17:58:02 UTC) #5
Florian Schneider
On 2016/11/15 17:58:02, Florian Schneider wrote: > Please provide a CL description with the reason ...
4 years, 1 month ago (2016-11-15 18:13:45 UTC) #7
kustermann
4 years, 1 month ago (2016-11-16 20:03:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a4dbbaae1045f43a65011584d2746985d79e717b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698