Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 2504693002: Mark lazily-patched native calls correctly as patchable. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1076 matching lines...) Expand 10 before | Expand all | Expand 10 after
1087 void FlowGraphCompiler::GenerateCall(TokenPosition token_pos, 1087 void FlowGraphCompiler::GenerateCall(TokenPosition token_pos,
1088 const StubEntry& stub_entry, 1088 const StubEntry& stub_entry,
1089 RawPcDescriptors::Kind kind, 1089 RawPcDescriptors::Kind kind,
1090 LocationSummary* locs) { 1090 LocationSummary* locs) {
1091 __ BranchLink(stub_entry); 1091 __ BranchLink(stub_entry);
1092 AddCurrentDescriptor(kind, Thread::kNoDeoptId, token_pos); 1092 AddCurrentDescriptor(kind, Thread::kNoDeoptId, token_pos);
1093 RecordSafepoint(locs); 1093 RecordSafepoint(locs);
1094 } 1094 }
1095 1095
1096 1096
1097 void FlowGraphCompiler::GeneratePatchableCall(TokenPosition token_pos,
1098 const StubEntry& stub_entry,
1099 RawPcDescriptors::Kind kind,
1100 LocationSummary* locs) {
1101 __ BranchLinkPatchable(stub_entry);
1102 AddCurrentDescriptor(kind, Thread::kNoDeoptId, token_pos);
1103 RecordSafepoint(locs);
1104 }
1105
1106
1097 void FlowGraphCompiler::GenerateDartCall(intptr_t deopt_id, 1107 void FlowGraphCompiler::GenerateDartCall(intptr_t deopt_id,
1098 TokenPosition token_pos, 1108 TokenPosition token_pos,
1099 const StubEntry& stub_entry, 1109 const StubEntry& stub_entry,
1100 RawPcDescriptors::Kind kind, 1110 RawPcDescriptors::Kind kind,
1101 LocationSummary* locs) { 1111 LocationSummary* locs) {
1102 __ BranchLinkPatchable(stub_entry); 1112 __ BranchLinkPatchable(stub_entry);
1103 AddCurrentDescriptor(kind, deopt_id, token_pos); 1113 AddCurrentDescriptor(kind, deopt_id, token_pos);
1104 RecordSafepoint(locs); 1114 RecordSafepoint(locs);
1105 // Marks either the continuation point in unoptimized code or the 1115 // Marks either the continuation point in unoptimized code or the
1106 // deoptimization point in optimized code, after call. 1116 // deoptimization point in optimized code, after call.
(...skipping 797 matching lines...) Expand 10 before | Expand all | Expand 10 after
1904 DRegister dreg = EvenDRegisterOf(reg); 1914 DRegister dreg = EvenDRegisterOf(reg);
1905 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1915 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1906 } 1916 }
1907 1917
1908 1918
1909 #undef __ 1919 #undef __
1910 1920
1911 } // namespace dart 1921 } // namespace dart
1912 1922
1913 #endif // defined TARGET_ARCH_ARM 1923 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler.h ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698