Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2504533002: Revert of Disable two tests in mojo_system_unittests that are suspected to be timing out (Closed)

Created:
4 years, 1 month ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable two tests in mojo_system_unittests that are suspected to be timing out (patchset #2 id:20001 of https://codereview.chromium.org/2497203002/ ) Reason for revert: Issue 663998 still persists after this CL. Original issue's description: > Disable two tests in mojo_system_unittests that are suspected to be timing out > > BUG=663998 > TBR=pdr@chromium.org, timloh@chromium.org > > Committed: https://crrev.com/aae520affa1d2c4397bf4d4758a9ff48d5a0cc88 > Cr-Commit-Position: refs/heads/master@{#431847} TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=663998 Committed: https://crrev.com/ba86cdb48c680aa78a142dee329d1c57ba22b00a Cr-Commit-Position: refs/heads/master@{#432117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M mojo/edk/embedder/embedder_unittest.cc View 1 chunk +1 line, -9 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hiroshige
Created Revert of Disable two tests in mojo_system_unittests that are suspected to be timing out
4 years, 1 month ago (2016-11-15 05:37:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504533002/1
4 years, 1 month ago (2016-11-15 05:38:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 05:39:15 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 05:42:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba86cdb48c680aa78a142dee329d1c57ba22b00a
Cr-Commit-Position: refs/heads/master@{#432117}

Powered by Google App Engine
This is Rietveld 408576698