Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: mojo/edk/system/multiprocess_message_pipe_unittest.cc

Issue 2504533002: Revert of Disable two tests in mojo_system_unittests that are suspected to be timing out (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/edk/embedder/embedder_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 #include <stdio.h> 7 #include <stdio.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 857 matching lines...) Expand 10 before | Expand all | Expand 10 after
868 868
869 WriteMessage(h, "exit"); 869 WriteMessage(h, "exit");
870 END_CHILD() 870 END_CHILD()
871 871
872 CloseHandle(echo_factory_proxy); 872 CloseHandle(echo_factory_proxy);
873 CloseHandle(echo_proxy_a); 873 CloseHandle(echo_proxy_a);
874 CloseHandle(echo_proxy_b); 874 CloseHandle(echo_proxy_b);
875 CloseHandle(echo_proxy_c); 875 CloseHandle(echo_proxy_c);
876 } 876 }
877 877
878 #if !defined(OS_ANDROID)
879 // This test is suspected to be flaky on android https://crbug.com/663998
880 // and thus disabled on android.
881 TEST_P(MultiprocessMessagePipeTestWithPeerSupport, 878 TEST_P(MultiprocessMessagePipeTestWithPeerSupport,
882 ChannelPipesWithMultipleChildren) { 879 ChannelPipesWithMultipleChildren) {
883 RUN_CHILD_ON_PIPE(ChannelEchoClient, a) 880 RUN_CHILD_ON_PIPE(ChannelEchoClient, a)
884 RUN_CHILD_ON_PIPE(ChannelEchoClient, b) 881 RUN_CHILD_ON_PIPE(ChannelEchoClient, b)
885 VerifyEcho(a, "hello child 0"); 882 VerifyEcho(a, "hello child 0");
886 VerifyEcho(b, "hello child 1"); 883 VerifyEcho(b, "hello child 1");
887 884
888 WriteMessage(a, "exit"); 885 WriteMessage(a, "exit");
889 WriteMessage(b, "exit"); 886 WriteMessage(b, "exit");
890 END_CHILD() 887 END_CHILD()
891 END_CHILD() 888 END_CHILD()
892 } 889 }
893 #endif
894 890
895 // Reads and turns a pipe handle some number of times to create lots of 891 // Reads and turns a pipe handle some number of times to create lots of
896 // transient proxies. 892 // transient proxies.
897 DEFINE_TEST_CLIENT_TEST_WITH_PIPE(PingPongPipeClient, 893 DEFINE_TEST_CLIENT_TEST_WITH_PIPE(PingPongPipeClient,
898 MultiprocessMessagePipeTest, h) { 894 MultiprocessMessagePipeTest, h) {
899 const size_t kNumBounces = 50; 895 const size_t kNumBounces = 50;
900 MojoHandle p0, p1; 896 MojoHandle p0, p1;
901 ReadMessageWithHandles(h, &p0, 1); 897 ReadMessageWithHandles(h, &p0, 1);
902 ReadMessageWithHandles(h, &p1, 1); 898 ReadMessageWithHandles(h, &p1, 1);
903 for (size_t i = 0; i < kNumBounces; ++i) { 899 for (size_t i = 0; i < kNumBounces; ++i) {
(...skipping 522 matching lines...) Expand 10 before | Expand all | Expand 10 after
1426 INSTANTIATE_TEST_CASE_P( 1422 INSTANTIATE_TEST_CASE_P(
1427 , 1423 ,
1428 MultiprocessMessagePipeTestWithPeerSupport, 1424 MultiprocessMessagePipeTestWithPeerSupport,
1429 testing::Values(test::MojoTestBase::LaunchType::CHILD, 1425 testing::Values(test::MojoTestBase::LaunchType::CHILD,
1430 test::MojoTestBase::LaunchType::PEER, 1426 test::MojoTestBase::LaunchType::PEER,
1431 test::MojoTestBase::LaunchType::NAMED_CHILD, 1427 test::MojoTestBase::LaunchType::NAMED_CHILD,
1432 test::MojoTestBase::LaunchType::NAMED_PEER)); 1428 test::MojoTestBase::LaunchType::NAMED_PEER));
1433 } // namespace 1429 } // namespace
1434 } // namespace edk 1430 } // namespace edk
1435 } // namespace mojo 1431 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/edk/embedder/embedder_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698