Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2504443002: Cleanup: Move SchedulerWorkerPoolImpl ForTesting Methods to the Bottom of the Public Section (Closed)

Created:
4 years, 1 month ago by robliao
Modified:
4 years, 1 month ago
Reviewers:
gab, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Move SchedulerWorkerPoolImpl ForTesting Methods to the Bottom of the Public Section BUG= Committed: https://crrev.com/27e3faf05d09754b24f5427648a91a9552c52e2e Cr-Commit-Position: refs/heads/master@{#431991}

Patch Set 1 #

Patch Set 2 : Clang Format Is Now Enforced in Base #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M base/task_scheduler/scheduler_worker_pool_impl.h View 2 chunks +15 lines, -15 lines 0 comments Download
M base/task_scheduler/scheduler_worker_pool_impl.cc View 1 2 chunks +20 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
robliao
4 years, 1 month ago (2016-11-14 21:21:29 UTC) #4
fdoray
lgtm
4 years, 1 month ago (2016-11-14 21:31:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504443002/1
4 years, 1 month ago (2016-11-14 22:14:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/303744)
4 years, 1 month ago (2016-11-14 22:40:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504443002/20001
4 years, 1 month ago (2016-11-14 22:42:54 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-14 23:55:15 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 00:02:14 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27e3faf05d09754b24f5427648a91a9552c52e2e
Cr-Commit-Position: refs/heads/master@{#431991}

Powered by Google App Engine
This is Rietveld 408576698