Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4524)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl.cc

Issue 2504443002: Cleanup: Move SchedulerWorkerPoolImpl ForTesting Methods to the Bottom of the Public Section (Closed)
Patch Set: Clang Format Is Now Enforced in Base Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_worker_pool_impl.cc
diff --git a/base/task_scheduler/scheduler_worker_pool_impl.cc b/base/task_scheduler/scheduler_worker_pool_impl.cc
index 155f42dc132051ef24e91d27d8a4e512450a664d..f15cc937c7122d62b05335de9644c38ee907be50 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl.cc
+++ b/base/task_scheduler/scheduler_worker_pool_impl.cc
@@ -320,26 +320,6 @@ std::unique_ptr<SchedulerWorkerPoolImpl> SchedulerWorkerPoolImpl::Create(
return nullptr;
}
-void SchedulerWorkerPoolImpl::WaitForAllWorkersIdleForTesting() {
- AutoSchedulerLock auto_lock(idle_workers_stack_lock_);
- while (idle_workers_stack_.Size() < workers_.size())
- idle_workers_stack_cv_for_testing_->Wait();
-}
-
-void SchedulerWorkerPoolImpl::JoinForTesting() {
- DCHECK(!CanWorkerDetachForTesting() || suggested_reclaim_time_.is_max()) <<
- "Workers can detach during join.";
- for (const auto& worker : workers_)
- worker->JoinForTesting();
-
- DCHECK(!join_for_testing_returned_.IsSignaled());
- join_for_testing_returned_.Signal();
-}
-
-void SchedulerWorkerPoolImpl::DisallowWorkerDetachmentForTesting() {
- worker_detachment_disallowed_.Set();
-}
-
scoped_refptr<TaskRunner> SchedulerWorkerPoolImpl::CreateTaskRunnerWithTraits(
const TaskTraits& traits) {
return make_scoped_refptr(new SchedulerParallelTaskRunner(traits, this));
@@ -452,6 +432,26 @@ void SchedulerWorkerPoolImpl::GetHistograms(
histograms->push_back(num_tasks_between_waits_histogram_);
}
+void SchedulerWorkerPoolImpl::WaitForAllWorkersIdleForTesting() {
+ AutoSchedulerLock auto_lock(idle_workers_stack_lock_);
+ while (idle_workers_stack_.Size() < workers_.size())
+ idle_workers_stack_cv_for_testing_->Wait();
+}
+
+void SchedulerWorkerPoolImpl::JoinForTesting() {
+ DCHECK(!CanWorkerDetachForTesting() || suggested_reclaim_time_.is_max())
+ << "Workers can detach during join.";
+ for (const auto& worker : workers_)
+ worker->JoinForTesting();
+
+ DCHECK(!join_for_testing_returned_.IsSignaled());
+ join_for_testing_returned_.Signal();
+}
+
+void SchedulerWorkerPoolImpl::DisallowWorkerDetachmentForTesting() {
+ worker_detachment_disallowed_.Set();
+}
+
SchedulerWorkerPoolImpl::SchedulerSingleThreadTaskRunner::
SchedulerSingleThreadTaskRunner(const TaskTraits& traits,
SchedulerWorkerPool* worker_pool,
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698