Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2504383002:
Enable no-compile tests on non-windows and non-ios clang (Closed)
DescriptionEnable no-compile tests on non-windows and non-ios clang
BUG=105388
Committed: https://crrev.com/2c255b993eed2520629078b6f89992edd4303563
Cr-Commit-Position: refs/heads/master@{#440024}
Patch Set 1 #Patch Set 2 : enable all for dryrun #Patch Set 3 : no ios #Messages
Total messages: 37 (22 generated)
wychen@chromium.org changed reviewers: + dcheng@chromium.org, thakis@chromium.org
PTAL
lgtm
Description was changed from ========== Enable no-compile tests on non-windows clang BUG=105388 ========== to ========== Enable no-compile tests on non-windows clang BUG=105388 ==========
wychen@chromium.org changed reviewers: - thakis@chromium.org
wychen@chromium.org changed reviewers: + jbudorick@chromium.org, thakis@chromium.org
Nico, what do you say? I'll notify the sheriffs before landing this.
Sure, let's give it a try, lgtm. (Why only non-Windows?)
On 2016/12/02 02:59:58, Nico wrote: > Sure, let's give it a try, lgtm. > > (Why only non-Windows?) This mirrors build/nocompile.gypi when it was removed. The condition was: 'OS!="win" and clang==1' If this CL sticks, we can consider widen up the support.
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
I love Rugby and it is my favorite sport to watch. Though I know to the application.I love to browse it. This was amazing post on chrome. You can find the best term papers for your academic writing task http://www.essayscampus.com/
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
On 2016/12/07 09:32:28, wychen wrote:
> On 2016/12/02 02:59:58, Nico wrote:
> > Sure, let's give it a try, lgtm.
> >
> > (Why only non-Windows?)
>
> This mirrors build/nocompile.gypi when it was removed.
> The condition was:
> 'OS!="win" and clang==1'
>
> If this CL sticks, we can consider widen up the support.
Looks like tools/nocompile_driver.py doesn't support windows yet, but this can
be fixed.
File "../../tools/nocompile_driver.py", line 230, in StartTest
stderr=subprocess.PIPE)
WindowsError: [Error 2] The system cannot find the file specified
iOS also has issues, so it's excluded as well.
../../build/build_config.h:37:10: fatal error: 'TargetConditionals.h' file not
found
#include <TargetConditionals.h>
In file included from ../../base/logging.h:10:
/b/build/slave/ios-device/build/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/cassert:21:10:
fatal error: 'assert.h' file not found
#include <assert.h>
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/09 08:18:25, wychen wrote: > On 2016/12/07 09:32:28, wychen wrote: > > On 2016/12/02 02:59:58, Nico wrote: > > > Sure, let's give it a try, lgtm. > > > > > > (Why only non-Windows?) > > > > This mirrors build/nocompile.gypi when it was removed. > > The condition was: > > 'OS!="win" and clang==1' > > > > If this CL sticks, we can consider widen up the support. > > Looks like tools/nocompile_driver.py doesn't support windows yet, but this can > be fixed. > > File "../../tools/nocompile_driver.py", line 230, in StartTest > stderr=subprocess.PIPE) > WindowsError: [Error 2] The system cannot find the file specified > > iOS also has issues, so it's excluded as well. > > ../../build/build_config.h:37:10: fatal error: 'TargetConditionals.h' file not > found > #include <TargetConditionals.h> > > In file included from ../../base/logging.h:10: > /b/build/slave/ios-device/build/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/cassert:21:10: > fatal error: 'assert.h' file not found > #include <assert.h> IMO, let's just get the original relanded and see if it's flaky. If it's not, we can experiment with enabling it on more platforms.
On 2016/12/09 08:20:31, dcheng wrote: > On 2016/12/09 08:18:25, wychen wrote: > > On 2016/12/07 09:32:28, wychen wrote: > > > On 2016/12/02 02:59:58, Nico wrote: > > > > Sure, let's give it a try, lgtm. > > > > > > > > (Why only non-Windows?) > > > > > > This mirrors build/nocompile.gypi when it was removed. > > > The condition was: > > > 'OS!="win" and clang==1' > > > > > > If this CL sticks, we can consider widen up the support. > > > > Looks like tools/nocompile_driver.py doesn't support windows yet, but this can > > be fixed. > > > > File "../../tools/nocompile_driver.py", line 230, in StartTest > > stderr=subprocess.PIPE) > > WindowsError: [Error 2] The system cannot find the file specified > > > > iOS also has issues, so it's excluded as well. > > > > ../../build/build_config.h:37:10: fatal error: 'TargetConditionals.h' file not > > found > > #include <TargetConditionals.h> > > > > In file included from ../../base/logging.h:10: > > > /b/build/slave/ios-device/build/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/cassert:21:10: > > fatal error: 'assert.h' file not found > > #include <assert.h> > > IMO, let's just get the original relanded and see if it's flaky. If it's not, we > can experiment with enabling it on more platforms. Totally agree. I'll land "!is_win && !is_ios && is_clang" first.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
(I agree too, hence my lg last week) On Dec 9, 2016 3:25 AM, <wychen@chromium.org> wrote: > On 2016/12/09 08:20:31, dcheng wrote: > > On 2016/12/09 08:18:25, wychen wrote: > > > On 2016/12/07 09:32:28, wychen wrote: > > > > On 2016/12/02 02:59:58, Nico wrote: > > > > > Sure, let's give it a try, lgtm. > > > > > > > > > > (Why only non-Windows?) > > > > > > > > This mirrors build/nocompile.gypi when it was removed. > > > > The condition was: > > > > 'OS!="win" and clang==1' > > > > > > > > If this CL sticks, we can consider widen up the support. > > > > > > Looks like tools/nocompile_driver.py doesn't support windows yet, but > this > can > > > be fixed. > > > > > > File "../../tools/nocompile_driver.py", line 230, in StartTest > > > stderr=subprocess.PIPE) > > > WindowsError: [Error 2] The system cannot find the file specified > > > > > > iOS also has issues, so it's excluded as well. > > > > > > ../../build/build_config.h:37:10: fatal error: 'TargetConditionals.h' > file > not > > > found > > > #include <TargetConditionals.h> > > > > > > In file included from ../../base/logging.h:10: > > > > > > /b/build/slave/ios-device/build/src/third_party/llvm- > build/Release+Asserts/bin/../include/c++/v1/cassert:21:10: > > > fatal error: 'assert.h' file not found > > > #include <assert.h> > > > > IMO, let's just get the original relanded and see if it's flaky. If it's > not, > we > > can experiment with enabling it on more platforms. > > Totally agree. I'll land "!is_win && !is_ios && is_clang" first. > > https://codereview.chromium.org/2504383002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Description was changed from ========== Enable no-compile tests on non-windows clang BUG=105388 ========== to ========== Enable no-compile tests on non-windows and non-ios clang BUG=105388 ==========
The CQ bit was checked by wychen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org, dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/2504383002/#ps40001 (title: "no ios")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482292717016950,
"parent_rev": "b052792fe9f3fd1cbcd4998f0ca2902995871dc8", "commit_rev":
"3c985ed2fe3a44b0281da6aa6263119ed56a3d7b"}
Message was sent while issue was closed.
Description was changed from ========== Enable no-compile tests on non-windows and non-ios clang BUG=105388 ========== to ========== Enable no-compile tests on non-windows and non-ios clang BUG=105388 Review-Url: https://codereview.chromium.org/2504383002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Enable no-compile tests on non-windows and non-ios clang BUG=105388 Review-Url: https://codereview.chromium.org/2504383002 ========== to ========== Enable no-compile tests on non-windows and non-ios clang BUG=105388 Committed: https://crrev.com/2c255b993eed2520629078b6f89992edd4303563 Cr-Commit-Position: refs/heads/master@{#440024} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2c255b993eed2520629078b6f89992edd4303563 Cr-Commit-Position: refs/heads/master@{#440024}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2593933002/ by wychen@chromium.org. The reason for reverting is: Break Mac compilation. https://build.chromium.org/p/chromium/builders/Mac/builds/22001/steps/compile....
Message was sent while issue was closed.
Reincarnated here: https://codereview.chromium.org/2594943002/ |
