Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 250433002: PNaCl documentation: add SIMD vectors. (Closed)

Created:
6 years, 8 months ago by JF
Modified:
6 years, 7 months ago
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Visibility:
Public.

Description

PNaCl documentation: add SIMD vectors. R= dschuff@chromium.org, nfullagar@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=2205 TEST= none NOTRY=true (documentation only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265948

Patch Set 1 #

Total comments: 11

Patch Set 2 : Address dschuff's comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -83 lines) Patch
M native_client_sdk/doc_generated/_static/pygments.css View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/faq.html View 2 chunks +5 lines, -1 line 0 comments Download
M native_client_sdk/doc_generated/nacl-and-pnacl.html View 1 1 chunk +3 lines, -5 lines 0 comments Download
M native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html View 1 3 chunks +142 lines, -25 lines 1 comment Download
M native_client_sdk/doc_generated/reference/pnacl-undefined-behavior.html View 1 2 chunks +12 lines, -1 line 0 comments Download
M native_client_sdk/doc_generated/sdk/release-notes.html View 1 15 chunks +43 lines, -34 lines 0 comments Download
M native_client_sdk/doc_generated/sitemap.html View 2 chunks +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/faq.rst View 3 chunks +7 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/nacl-and-pnacl.rst View 1 1 chunk +3 lines, -5 lines 0 comments Download
M native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst View 1 2 chunks +105 lines, -8 lines 0 comments Download
M native_client_sdk/src/doc/reference/pnacl-undefined-behavior.rst View 1 1 chunk +12 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/sdk/release-notes.rst View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
JF
6 years, 8 months ago (2014-04-24 02:49:22 UTC) #1
Derek Schuff
https://codereview.chromium.org/250433002/diff/1/native_client_sdk/doc_generated/_static/pygments.css File native_client_sdk/doc_generated/_static/pygments.css (right): https://codereview.chromium.org/250433002/diff/1/native_client_sdk/doc_generated/_static/pygments.css#newcode16 native_client_sdk/doc_generated/_static/pygments.css:16: .highlight .go { color: #333333 } /* Generic.Output */ ...
6 years, 8 months ago (2014-04-24 16:06:19 UTC) #2
JF
https://codereview.chromium.org/250433002/diff/1/native_client_sdk/src/doc/nacl-and-pnacl.rst File native_client_sdk/src/doc/nacl-and-pnacl.rst (right): https://codereview.chromium.org/250433002/diff/1/native_client_sdk/src/doc/nacl-and-pnacl.rst#newcode113 native_client_sdk/src/doc/nacl-and-pnacl.rst:113: offer high-performance equivalents. On 2014/04/24 16:06:20, Derek Schuff wrote: ...
6 years, 8 months ago (2014-04-24 16:16:29 UTC) #3
Derek Schuff
lgtm
6 years, 8 months ago (2014-04-24 16:50:17 UTC) #4
JF
The CQ bit was checked by jfb@chromium.org
6 years, 8 months ago (2014-04-24 16:59:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfb@chromium.org/250433002/20001
6 years, 8 months ago (2014-04-24 17:00:55 UTC) #6
commit-bot: I haz the power
Change committed as 265948
6 years, 8 months ago (2014-04-24 17:07:49 UTC) #7
nfullagar1
https://codereview.chromium.org/250433002/diff/20001/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html File native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html (right): https://codereview.chromium.org/250433002/diff/20001/native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html#newcode296 native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html:296: <li>Conversion to/from floating-point and signed/unsigned integer.</li> A few comments ...
6 years, 8 months ago (2014-04-24 23:25:32 UTC) #8
JF
6 years, 7 months ago (2014-04-28 16:43:22 UTC) #9
Message was sent while issue was closed.
On 2014/04/24 23:25:32, nfullagar1 wrote:
>
https://codereview.chromium.org/250433002/diff/20001/native_client_sdk/doc_ge...
> File
native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html
> (right):
> 
>
https://codereview.chromium.org/250433002/diff/20001/native_client_sdk/doc_ge...
>
native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html:296:
> <li>Conversion to/from floating-point and signed/unsigned integer.</li>
> A few comments that should be addressed in a follow up CL -
>   C-style casts on vectors do no conversion, they only change the type while
> keeping the bits the same.  It follows C-style casts on vectors do not zero
> extend or sign extend.
> 
> Use __builtin_convertvector() to convert between float and integer vectors. 
> __builtin_convertvector() will truncate when converting float to int.
> 
> When support for vector sizes other than 128bit come online, then
> __builtin_convertvector() can also be used to zero or sign extend between
> different sized fixed point formats, providing the src and dest types have the
> same number of elements.


Improved here:
  https://codereview.chromium.org/255813009

We do currently support truncation/zero/sign extension but AFAIK they can't be
expressed from C: we can do so to/from bool vectors that have the same number of
elements. I've removed this from the docs for now since it's not very useful to
document something that can't be used!

Powered by Google App Engine
This is Rietveld 408576698