Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25043005: Add better help information to quic_client and quic_server. Also, (Closed)

Created:
7 years, 2 months ago by Ryan Hamilton
Modified:
7 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Add better help information to quic_client and quic_server. Also, modify the quic_client to print out the response contents. Merge internal change: 53403247 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227365 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227558

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : DISABLE lame test #

Patch Set 5 : Rebase #

Patch Set 6 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -17 lines) Patch
M net/tools/quic/quic_client.h View 3 chunks +13 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client.cc View 5 chunks +28 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 2 3 4 5 3 chunks +20 lines, -5 lines 0 comments Download
M net/tools/quic/quic_reliable_client_stream_test.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_server_bin.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/spdy_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Ryan Hamilton
7 years, 2 months ago (2013-09-29 04:07:50 UTC) #1
ramant (doing other things)
lgtm https://codereview.chromium.org/25043005/diff/3001/net/tools/quic/quic_client_bin.cc File net/tools/quic/quic_client_bin.cc (right): https://codereview.chromium.org/25043005/diff/3001/net/tools/quic/quic_client_bin.cc#newcode7 net/tools/quic/quic_client_bin.cc:7: // nit: "specified onp the" -> "specified on ...
7 years, 2 months ago (2013-09-29 22:43:53 UTC) #2
Ryan Hamilton
https://codereview.chromium.org/25043005/diff/3001/net/tools/quic/quic_client_bin.cc File net/tools/quic/quic_client_bin.cc (right): https://codereview.chromium.org/25043005/diff/3001/net/tools/quic/quic_client_bin.cc#newcode7 net/tools/quic/quic_client_bin.cc:7: // On 2013/09/29 22:43:53, ramant wrote: > nit: "specified ...
7 years, 2 months ago (2013-09-30 15:42:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/25043005/8001
7 years, 2 months ago (2013-09-30 15:42:44 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=173780
7 years, 2 months ago (2013-09-30 21:53:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/25043005/38001
7 years, 2 months ago (2013-10-07 19:52:04 UTC) #6
commit-bot: I haz the power
Change committed as 227365
7 years, 2 months ago (2013-10-07 22:39:56 UTC) #7
Ryan Hamilton
On 2013/10/07 22:39:56, I haz the power (commit-bot) wrote: > Change committed as 227365 Reverted. ...
7 years, 2 months ago (2013-10-07 23:12:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/25043005/62001
7 years, 2 months ago (2013-10-07 23:13:45 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-08 01:04:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/25043005/62001
7 years, 2 months ago (2013-10-08 17:02:40 UTC) #11
commit-bot: I haz the power
7 years, 2 months ago (2013-10-08 19:00:51 UTC) #12
Message was sent while issue was closed. 
Change committed as 227558

Powered by Google App Engine
This is Rietveld 408576698