Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2504233005: Explicitly mention SHA-1 as a possible cause in the weak cert signature interstitial. (Closed)

Created:
4 years, 1 month ago by lgarron
Modified:
4 years, 1 month ago
Reviewers:
meacer
CC:
chromium-reviews, emilyschechter, Ryan Sleevi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly mention SHA-1 as a possible cause in the weak cert signature interstitial. In the near future (starting in Chrome 56), this error will most often be triggered by the deprecation of SHA-1 signed certs. Explicitly mentioning SHA-1 in the advanced details gives a strong hint about the likely cause to anyone who does not know the ins and outs of the SHA-1 deprecation, but has heard about it. BUG=653691 Committed: https://crrev.com/f3f60a5708505a97dd7761b60f39eac3f78a54dd Cr-Commit-Position: refs/heads/master@{#433388}

Patch Set 1 : Explicitly mention SHA-1 as a possible cause in the weak cert signature interstitial. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/ssl_errors_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
lgarron
meacer@, could you review?
4 years, 1 month ago (2016-11-17 07:54:36 UTC) #4
meacer
Lgtm, as long as the string is approved by UI.
4 years, 1 month ago (2016-11-17 20:06:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504233005/20001
4 years, 1 month ago (2016-11-19 02:37:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-19 03:25:31 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 03:28:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3f60a5708505a97dd7761b60f39eac3f78a54dd
Cr-Commit-Position: refs/heads/master@{#433388}

Powered by Google App Engine
This is Rietveld 408576698