Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2504183002: [turbofan] Fix bogus representation for {kCheckTaggedHole}. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix bogus representation for {kCheckTaggedHole}. The operator in question is guaranteed to produce a tagged value that is not equal to the-hole, it however does not guarantee the value to be a HeapObject. The correct representation hence is {kTagged}. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-665587 BUG=chromium:665587 Committed: https://crrev.com/31a8ec776241d97d59e89d46cf184342bab8720f Cr-Commit-Position: refs/heads/master@{#41032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-665587.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 1 month ago (2016-11-16 11:51:06 UTC) #1
Benedikt Meurer
LGTM, thanks.
4 years, 1 month ago (2016-11-16 11:57:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504183002/1
4 years, 1 month ago (2016-11-16 12:50:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 12:52:55 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:36:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31a8ec776241d97d59e89d46cf184342bab8720f
Cr-Commit-Position: refs/heads/master@{#41032}

Powered by Google App Engine
This is Rietveld 408576698