Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: src/compiler/simplified-lowering.cc

Issue 2504183002: [turbofan] Fix bogus representation for {kCheckTaggedHole}. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-665587.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/simplified-lowering.h" 5 #include "src/compiler/simplified-lowering.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/address-map.h" 9 #include "src/address-map.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 2448 matching lines...) Expand 10 before | Expand all | Expand 10 after
2459 ProcessInput(node, 0, UseInfo::TruncatingFloat64()); 2459 ProcessInput(node, 0, UseInfo::TruncatingFloat64());
2460 ProcessRemainingInputs(node, 1); 2460 ProcessRemainingInputs(node, 1);
2461 SetOutput(node, MachineRepresentation::kFloat64); 2461 SetOutput(node, MachineRepresentation::kFloat64);
2462 if (truncation.IsUsedAsFloat64() && 2462 if (truncation.IsUsedAsFloat64() &&
2463 mode == CheckFloat64HoleMode::kAllowReturnHole) { 2463 mode == CheckFloat64HoleMode::kAllowReturnHole) {
2464 if (lower()) DeferReplacement(node, node->InputAt(0)); 2464 if (lower()) DeferReplacement(node, node->InputAt(0));
2465 } 2465 }
2466 return; 2466 return;
2467 } 2467 }
2468 case IrOpcode::kCheckTaggedHole: { 2468 case IrOpcode::kCheckTaggedHole: {
2469 VisitUnop(node, UseInfo::AnyTagged(), 2469 VisitUnop(node, UseInfo::AnyTagged(), MachineRepresentation::kTagged);
2470 MachineRepresentation::kTaggedPointer);
2471 return; 2470 return;
2472 } 2471 }
2473 case IrOpcode::kConvertTaggedHoleToUndefined: { 2472 case IrOpcode::kConvertTaggedHoleToUndefined: {
2474 if (InputIs(node, Type::NumberOrOddball()) && 2473 if (InputIs(node, Type::NumberOrOddball()) &&
2475 truncation.IsUsedAsWord32()) { 2474 truncation.IsUsedAsWord32()) {
2476 // Propagate the Word32 truncation. 2475 // Propagate the Word32 truncation.
2477 VisitUnop(node, UseInfo::TruncatingWord32(), 2476 VisitUnop(node, UseInfo::TruncatingWord32(),
2478 MachineRepresentation::kWord32); 2477 MachineRepresentation::kWord32);
2479 if (lower()) DeferReplacement(node, node->InputAt(0)); 2478 if (lower()) DeferReplacement(node, node->InputAt(0));
2480 } else if (InputIs(node, Type::NumberOrOddball()) && 2479 } else if (InputIs(node, Type::NumberOrOddball()) &&
(...skipping 926 matching lines...) Expand 10 before | Expand all | Expand 10 after
3407 isolate(), graph()->zone(), callable.descriptor(), 0, flags, 3406 isolate(), graph()->zone(), callable.descriptor(), 0, flags,
3408 Operator::kNoProperties); 3407 Operator::kNoProperties);
3409 to_number_operator_.set(common()->Call(desc)); 3408 to_number_operator_.set(common()->Call(desc));
3410 } 3409 }
3411 return to_number_operator_.get(); 3410 return to_number_operator_.get();
3412 } 3411 }
3413 3412
3414 } // namespace compiler 3413 } // namespace compiler
3415 } // namespace internal 3414 } // namespace internal
3416 } // namespace v8 3415 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-665587.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698