Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2504173002: When placing a float, pay attention to its final logical top. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When placing a float, pay attention to its final logical top. Subsequent floats may not be placed above this location. BUG=665804 Committed: https://crrev.com/e92bd951db144e36d9235557a01d18703c2755ce Cr-Commit-Position: refs/heads/master@{#432503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/block/float/float-on-line-large-and-small-float-below.html View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
This was supposed to fix a suspected regression introduced by https://codereview.chromium.org/2486413002/ . It turned out ...
4 years, 1 month ago (2016-11-16 12:18:32 UTC) #6
szager1
lgtm
4 years, 1 month ago (2016-11-16 15:35:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2504173002/1
4 years, 1 month ago (2016-11-16 15:54:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 15:59:50 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 16:05:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e92bd951db144e36d9235557a01d18703c2755ce
Cr-Commit-Position: refs/heads/master@{#432503}

Powered by Google App Engine
This is Rietveld 408576698