third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp - Issue 2504173002: When placing a float, pay attention to its final logical top.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 2504173002: When placing a float, pay attention to its final logical top. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

index 9254bcd7543d247f1bde258974d0d18653337882..0ea54917cca50e25c23a1fef7d706c8f4d92d9fb 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

@@ -3632,7 +3632,7 @@ bool LayoutBlockFlow::positionNewFloats(LayoutUnit logicalTop,

// unplaced floats in our list that come from somewhere else, we have a bug.

DCHECK_EQ(floatingObject.layoutObject()->containingBlock(), this);

- positionAndLayoutFloat(floatingObject, logicalTop);

+ logicalTop = positionAndLayoutFloat(floatingObject, logicalTop);

m_floatingObjects->addPlacedObject(floatingObject);

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/block/float/float-on-line-large-and-small-float-below.html ('k') | no next file » | no next file with comments »