Add NewTabPageRecyclerViewTest.

Add NewTabPageRecyclerViewTest.

* Adds test for clicking a suggestion, dismissing all, and dismissing with context menu.
* Bumps coverage of org.chromium.chrome.browser.ntp* from 53% to 57%.

BUG=659631
Committed: https://crrev.com/59a04c33c644823c1ded38f1b9f274c6d969db85
Cr-Commit-Position: refs/heads/master@{#432523}

[Michael van Ouwerkerk, 2016-11-16 14:28:35]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 14:28:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael van Ouwerkerk, 2016-11-16 14:30:57]

Description was changed from

==========
Add NewTabPageRecyclerViewTest.

BUG=659631
==========

to

==========
Add NewTabPageRecyclerViewTest.

* Adds test for clicking a suggestion, dismissing all, and dismissing with
context menu.
* Bumps coverage of org.chromium.chrome.browser.ntp* from 53% to 57%.

BUG=659631
==========

[Michael van Ouwerkerk, 2016-11-16 14:31:39]

mvanouwerkerk@chromium.org changed reviewers:
+ bauerb@chromium.org

[Michael van Ouwerkerk, 2016-11-16 14:31:39]

Bernhard, could you take a look please?

[Bernhard Bauer, 2016-11-16 15:31:53]

lgtm

https://codereview.chromium.org/2504113003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
(right):

https://codereview.chromium.org/2504113003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java:102:
fail(t.getMessage());
I'm not sure you need this -- IIRC the test runner catches exceptions anyway, so
you can just let them propagate.

[Michael van Ouwerkerk, 2016-11-16 16:00:23]

The CQ bit was checked by mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2016-11-16 16:00:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2504113003/#ps20001
(title: "Address review comment from bauerb.")

[Michael van Ouwerkerk, 2016-11-16 16:00:36]

https://codereview.chromium.org/2504113003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
(right):

https://codereview.chromium.org/2504113003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java:102:
fail(t.getMessage());
On 2016/11/16 15:31:53, Bernhard Bauer wrote:
> I'm not sure you need this -- IIRC the test runner catches exceptions anyway,
so
> you can just let them propagate.

Done.

[commit-bot: I haz the power, 2016-11-16 16:01:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 16:58:05]

Description was changed from

==========
Add NewTabPageRecyclerViewTest.

* Adds test for clicking a suggestion, dismissing all, and dismissing with
context menu.
* Bumps coverage of org.chromium.chrome.browser.ntp* from 53% to 57%.

BUG=659631
==========

to

==========
Add NewTabPageRecyclerViewTest.

* Adds test for clicking a suggestion, dismissing all, and dismissing with
context menu.
* Bumps coverage of org.chromium.chrome.browser.ntp* from 53% to 57%.

BUG=659631
==========

[commit-bot: I haz the power, 2016-11-16 16:58:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 17:18:06]

Description was changed from

==========
Add NewTabPageRecyclerViewTest.

* Adds test for clicking a suggestion, dismissing all, and dismissing with
context menu.
* Bumps coverage of org.chromium.chrome.browser.ntp* from 53% to 57%.

BUG=659631
==========

to

==========
Add NewTabPageRecyclerViewTest.

* Adds test for clicking a suggestion, dismissing all, and dismissing with
context menu.
* Bumps coverage of org.chromium.chrome.browser.ntp* from 53% to 57%.

BUG=659631

Committed: https://crrev.com/59a04c33c644823c1ded38f1b9f274c6d969db85
Cr-Commit-Position: refs/heads/master@{#432523}
==========

[commit-bot: I haz the power, 2016-11-16 17:18:07]

Patchset 2 (id:??) landed as
https://crrev.com/59a04c33c644823c1ded38f1b9f274c6d969db85
Cr-Commit-Position: refs/heads/master@{#432523}