Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5142)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2504113003: Add NewTabPageRecyclerViewTest. (Closed)
Patch Set: Address review comment from bauerb. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index 708c3b82cc23fe4084bd307f610d8fe3c53c0f7d..19719296650123cf8053cfd7d5b1645ec7de3745 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -384,6 +384,10 @@ public class NewTabPageAdapter
return RecyclerView.NO_POSITION;
}
+ public int getSignInPromoPosition() {
+ return getChildPositionOffset(mSigninPromo);
+ }
+
public int getBottomSpacerPosition() {
return getChildPositionOffset(mBottomSpacer);
}
@@ -567,7 +571,8 @@ public class NewTabPageAdapter
return mRecyclerView.findViewHolderForAdapterPosition(siblingPosDelta + swipePos);
}
- private boolean hasAllBeenDismissed() {
+ @VisibleForTesting
+ public boolean hasAllBeenDismissed() {
return mSections.isEmpty() && !mSigninPromo.isVisible();
}

Powered by Google App Engine
This is Rietveld 408576698