Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2503973002: Add image color space histograms (Closed)

Created:
4 years, 1 month ago by ccameron
Modified:
4 years, 1 month ago
Reviewers:
msarett, pdr., rkaplow, msarett1
CC:
ajuma+watch_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add image color space histograms Use the same binning as output color spaces, merge them into a helper function. This should help inform strategies for image decoding. BUG=44872 Committed: https://crrev.com/54e9f5e214d9dbc57df09d2669ab2d1a9bb8a780 Cr-Commit-Position: refs/heads/master@{#432636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp View 2 chunks +14 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 3 chunks +7 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
ccameron
Do histogramming in ImageDecoder::framebufferAtIndex -- this is because not all decoders specify a color space ...
4 years, 1 month ago (2016-11-15 20:54:04 UTC) #2
pdr.
LGTM. Can you do a quick test locally using chrome://histograms/ to double-check that the expected ...
4 years, 1 month ago (2016-11-15 21:13:57 UTC) #3
msarett
LGTM I'd like to think about histogramming the image/output gamuts as well. This will require ...
4 years, 1 month ago (2016-11-15 21:25:27 UTC) #5
rkaplow
lgtm
4 years, 1 month ago (2016-11-16 06:10:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503973002/1
4 years, 1 month ago (2016-11-16 18:33:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/68962)
4 years, 1 month ago (2016-11-16 20:22:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503973002/1
4 years, 1 month ago (2016-11-16 20:27:32 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 21:58:30 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 22:00:47 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54e9f5e214d9dbc57df09d2669ab2d1a9bb8a780
Cr-Commit-Position: refs/heads/master@{#432636}

Powered by Google App Engine
This is Rietveld 408576698