Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp

Issue 2503973002: Add image color space histograms (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp b/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp
index 78e2cf39cc1495617df421485de037f6c52926d7..6e2130c71e5bf807287025be497944ad1bab0625 100644
--- a/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp
+++ b/third_party/WebKit/Source/platform/graphics/BitmapImageMetrics.cpp
@@ -42,13 +42,24 @@ void BitmapImageMetrics::countImageOrientation(
orientationHistogram.count(orientation);
}
-void BitmapImageMetrics::countGamma(SkColorSpace* colorSpace) {
+void BitmapImageMetrics::countImageGamma(SkColorSpace* colorSpace) {
+ DEFINE_THREAD_SAFE_STATIC_LOCAL(
+ EnumerationHistogram, gammaNamedHistogram,
+ new EnumerationHistogram("Blink.ColorSpace.Source", GammaEnd));
+ gammaNamedHistogram.count(getColorSpaceGamma(colorSpace));
+}
+
+void BitmapImageMetrics::countOutputGamma(SkColorSpace* colorSpace) {
DEFINE_THREAD_SAFE_STATIC_LOCAL(
EnumerationHistogram, gammaNamedHistogram,
new EnumerationHistogram("Blink.ColorSpace.Destination", GammaEnd));
+ gammaNamedHistogram.count(getColorSpaceGamma(colorSpace));
+}
+BitmapImageMetrics::Gamma BitmapImageMetrics::getColorSpaceGamma(
+ SkColorSpace* colorSpace) {
+ Gamma gamma = GammaNull;
if (colorSpace) {
- Gamma gamma;
if (colorSpace->gammaCloseToSRGB()) {
gamma = GammaSRGB;
} else if (colorSpace->gammaIsLinear()) {
@@ -56,11 +67,8 @@ void BitmapImageMetrics::countGamma(SkColorSpace* colorSpace) {
} else {
gamma = GammaNonStandard;
}
-
- gammaNamedHistogram.count(gamma);
- } else {
- gammaNamedHistogram.count(GammaNull);
}
+ return gamma;
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698