Only call into the HOsrBuilder if required for OSR.

Refactoring such that loop builders only call into the HOsrBuilder if
compiling for OSR.

BUG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16990

[mvstanton, 2013-09-27 13:16:15]

Hi Michael, PTAL, thx!
---Michael

[Michael Starzinger, 2013-09-27 13:26:21]

LGTM with nits.

https://codereview.chromium.org/25039003/diff/1/src/hydrogen-osr.cc
File src/hydrogen-osr.cc (right):

https://codereview.chromium.org/25039003/diff/1/src/hydrogen-osr.cc#newcode40
src/hydrogen-osr.cc:40: HBasicBlock* HOsrBuilder::BuildOsrLoopEntry(
nit: Should fit into one line.

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.cc#newcode8625
src/hydrogen.cc:8625: HBasicBlock *HOptimizedGraphBuilder::BuildLoopEntry() {
nit: Asterisk sticks to the left.

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.cc#newcode8633
src/hydrogen.cc:8633: HBasicBlock* HOptimizedGraphBuilder::BuildLoopEntry(
nit: See comment in hydrogen.h about placement of these two functions.

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.h#newcode1784
src/hydrogen.h:1784: HOsrBuilder* osr() { return osr_; }
nit: Can be made const.

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.h#newcode1797
src/hydrogen.h:1797: HBasicBlock* BuildLoopEntry();
nit: Let's move these two declarations near CreateLoop(), this makes it clear
that they are counterparts to each other.

[mvstanton, 2013-09-27 13:31:43]

thanks very mich--
much.

https://codereview.chromium.org/25039003/diff/1/src/hydrogen-osr.cc
File src/hydrogen-osr.cc (right):

https://codereview.chromium.org/25039003/diff/1/src/hydrogen-osr.cc#newcode40
src/hydrogen-osr.cc:40: HBasicBlock* HOsrBuilder::BuildOsrLoopEntry(
On 2013/09/27 13:26:22, Michael Starzinger wrote:
> nit: Should fit into one line.

Done.

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.cc#newcode8625
src/hydrogen.cc:8625: HBasicBlock *HOptimizedGraphBuilder::BuildLoopEntry() {
On 2013/09/27 13:26:22, Michael Starzinger wrote:
> nit: Asterisk sticks to the left.

Done.

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.cc#newcode8633
src/hydrogen.cc:8633: HBasicBlock* HOptimizedGraphBuilder::BuildLoopEntry(
On 2013/09/27 13:26:22, Michael Starzinger wrote:
> nit: See comment in hydrogen.h about placement of these two functions.

Done.

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.h#newcode1784
src/hydrogen.h:1784: HOsrBuilder* osr() { return osr_; }
On 2013/09/27 13:26:22, Michael Starzinger wrote:
> nit: Can be made const.

Done.

https://codereview.chromium.org/25039003/diff/1/src/hydrogen.h#newcode1797
src/hydrogen.h:1797: HBasicBlock* BuildLoopEntry();
On 2013/09/27 13:26:22, Michael Starzinger wrote:
> nit: Let's move these two declarations near CreateLoop(), this makes it clear
> that they are counterparts to each other.

Done.

[mvstanton, 2013-09-27 13:38:13]

Committed patchset #2 manually as r16990 (presubmit successful).