Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: src/hydrogen-osr.h

Issue 25039003: Only call into the HOsrBuilder if required for OSR. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed nits Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-osr.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 27 matching lines...) Expand all
38 // Responsible for building graph parts related to OSR and otherwise 38 // Responsible for building graph parts related to OSR and otherwise
39 // setting up the graph to do an OSR compile. 39 // setting up the graph to do an OSR compile.
40 class HOsrBuilder : public ZoneObject { 40 class HOsrBuilder : public ZoneObject {
41 public: 41 public:
42 explicit HOsrBuilder(HOptimizedGraphBuilder* builder) 42 explicit HOsrBuilder(HOptimizedGraphBuilder* builder)
43 : unoptimized_frame_slots_(0), 43 : unoptimized_frame_slots_(0),
44 builder_(builder), 44 builder_(builder),
45 osr_entry_(NULL), 45 osr_entry_(NULL),
46 osr_loop_entry_(NULL), 46 osr_loop_entry_(NULL),
47 osr_values_(NULL) { } 47 osr_values_(NULL) { }
48
48 // Creates the loop entry block for the given statement, setting up OSR 49 // Creates the loop entry block for the given statement, setting up OSR
49 // entries as necessary, and sets the current block to the new block. 50 // entries as necessary, and sets the current block to the new block.
50 HBasicBlock* BuildPossibleOsrLoopEntry(IterationStatement* statement); 51 HBasicBlock* BuildOsrLoopEntry(IterationStatement* statement);
51 52
52 // Process the hydrogen graph after it has been completed, performing 53 // Process the hydrogen graph after it has been completed, performing
53 // any OSR-specific cleanups or changes. 54 // any OSR-specific cleanups or changes.
54 void FinishGraph(); 55 void FinishGraph();
55 56
56 // Process the OSR values and phis after initial graph optimization. 57 // Process the OSR values and phis after initial graph optimization.
57 void FinishOsrValues(); 58 void FinishOsrValues();
58 59
59 // Return the number of slots in the unoptimized frame at the entry to OSR. 60 // Return the number of slots in the unoptimized frame at the entry to OSR.
60 int UnoptimizedFrameSlots() const { 61 int UnoptimizedFrameSlots() const {
61 return unoptimized_frame_slots_; 62 return unoptimized_frame_slots_;
62 } 63 }
63 64
64 private:
65 HBasicBlock* BuildLoopEntry();
66 bool HasOsrEntryAt(IterationStatement* statement); 65 bool HasOsrEntryAt(IterationStatement* statement);
67 66
67 private:
68 int unoptimized_frame_slots_; 68 int unoptimized_frame_slots_;
69 HOptimizedGraphBuilder* builder_; 69 HOptimizedGraphBuilder* builder_;
70 HBasicBlock* osr_entry_; 70 HBasicBlock* osr_entry_;
71 HBasicBlock* osr_loop_entry_; 71 HBasicBlock* osr_loop_entry_;
72 ZoneList<HUnknownOSRValue*>* osr_values_; 72 ZoneList<HUnknownOSRValue*>* osr_values_;
73 }; 73 };
74 74
75 } } // namespace v8::internal 75 } } // namespace v8::internal
76 76
77 #endif // V8_HYDROGEN_OSR_H_ 77 #endif // V8_HYDROGEN_OSR_H_
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-osr.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698