Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2503883002: [ObjC ARC] Converts ios/chrome/browser/crash_report to ARC (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/crash_report to ARC Notable changes: * Removed dispatch_release calls, since GCD objects are managed with ARC now. BUG=665024 Committed: https://crrev.com/fd57e705d19544ea6cffba38d9b24058817e2d78 Cr-Commit-Position: refs/heads/master@{#432456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M ios/chrome/browser/crash_report/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/crash_report/breakpad_helper.mm View 3 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/crash_report/crash_report_background_uploader.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/browser/crash_report/crash_report_multi_parameter.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/crash_report/crash_report_user_application_state.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
stkhapugin
PTAL. This issue passed a downstream trybot.
4 years, 1 month ago (2016-11-15 14:39:08 UTC) #4
noyau (Ping after 24h)
lgtm
4 years, 1 month ago (2016-11-16 10:06:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503883002/1
4 years, 1 month ago (2016-11-16 10:07:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 11:04:33 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 11:06:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd57e705d19544ea6cffba38d9b24058817e2d78
Cr-Commit-Position: refs/heads/master@{#432456}

Powered by Google App Engine
This is Rietveld 408576698