Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: ios/chrome/browser/crash_report/breakpad_helper.mm

Issue 2503883002: [ObjC ARC] Converts ios/chrome/browser/crash_report to ARC (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/crash_report/breakpad_helper.mm
diff --git a/ios/chrome/browser/crash_report/breakpad_helper.mm b/ios/chrome/browser/crash_report/breakpad_helper.mm
index 252df3da7c5b61499a37109909f392706885147d..4ae4326a950f17503efd274a8578d9e974dc80fd 100644
--- a/ios/chrome/browser/crash_report/breakpad_helper.mm
+++ b/ios/chrome/browser/crash_report/breakpad_helper.mm
@@ -26,6 +26,10 @@
// is fixed. For now, put it at the end to avoid compiler errors.
#import "breakpad/src/client/ios/BreakpadController.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace breakpad_helper {
namespace {
@@ -194,7 +198,6 @@ void AddReportParameter(NSString* key, NSString* value, bool async) {
dispatch_semaphore_signal(semaphore);
}];
dispatch_semaphore_wait(semaphore, DISPATCH_TIME_FOREVER);
- dispatch_release(semaphore);
}
int GetCrashReportCount() {
@@ -205,7 +208,6 @@ int GetCrashReportCount() {
dispatch_semaphore_signal(semaphore);
}];
dispatch_semaphore_wait(semaphore, DISPATCH_TIME_FOREVER);
- dispatch_release(semaphore);
return outerCrashReportCount;
}
« no previous file with comments | « ios/chrome/browser/crash_report/BUILD.gn ('k') | ios/chrome/browser/crash_report/crash_report_background_uploader.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698