Register MediaUrlInterceptor with MediaPlayerRenderer

Register MediaUrlInterceptor with MediaPlayerRenderer

A recent review added RegisterMediaUrlInterceptor() to the
MediaPlayerRenderer.

The function was never used, because conditionally enabling it by using
base::FeatureList from AwMainDelegate::BasicStartupComplete() prevented
certain Java tests from running.

Using base::FeatureList is uncessary, because we can register the
MediaUrlInterceptor both in the BrowserMediaPlayerManager and the
MediaPlayerRenderer without any problems. This change adds the extra
registration

BUG=636588
Committed: https://crrev.com/20038e2480c5e8fd98615cc63a48db56b6da3eab
Cr-Commit-Position: refs/heads/master@{#432334}

[tguilbert, 2016-11-15 22:57:44]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 22:58:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 23:26:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:26:24]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tguilbert, 2016-11-15 23:39:05]

Patchset #2 (id:20001) has been deleted

[tguilbert, 2016-11-15 23:50:26]

tguilbert@chromium.org changed reviewers:
+ boliu@chromium.org

[tguilbert, 2016-11-15 23:50:27]

Hello! PTAL.

This is a follow up to:
https://codereview.chromium.org/2463533002/

I don't know why I thought this was a problem. Not using base::FeatureList
solves the issue, since registering the MediaUrlInterceptor in more than one
place is not a problem.

The cast_shell_linux trybot failure was caused by a failure that was just
reverted
(https://chromium.googlesource.com/chromium/src/+/9f25f76c28650c6d27dbdc972cf0...)

The webview tests that were failing in the previous review now pass.

Thanks!

[tguilbert, 2016-11-16 00:26:07]

The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 00:26:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 00:40:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 00:40:04]

Dry run: This issue passed the CQ dry run.

[boliu, 2016-11-16 00:48:02]

lgtm

[tguilbert, 2016-11-16 00:56:41]

The CQ bit was checked by tguilbert@chromium.org

[tguilbert, 2016-11-16 00:56:52]

On 2016/11/16 00:48:02, boliu wrote:
> lgtm

Thank you!

[commit-bot: I haz the power, 2016-11-16 00:57:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 01:23:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-16 01:28:46]

Description was changed from

==========
Register MediaUrlInterceptor with MediaPlayerRenderer

A recent review added RegisterMediaUrlInterceptor() to the
MediaPlayerRenderer.

The function was never used, because conditionally enabling it by using
base::FeatureList from AwMainDelegate::BasicStartupComplete() prevented
certain Java tests from running.

Using base::FeatureList is uncessary, because we can register the
MediaUrlInterceptor both in the BrowserMediaPlayerManager and the
MediaPlayerRenderer without any problems. This change adds the extra
registration

BUG=636588
==========

to

==========
Register MediaUrlInterceptor with MediaPlayerRenderer

A recent review added RegisterMediaUrlInterceptor() to the
MediaPlayerRenderer.

The function was never used, because conditionally enabling it by using
base::FeatureList from AwMainDelegate::BasicStartupComplete() prevented
certain Java tests from running.

Using base::FeatureList is uncessary, because we can register the
MediaUrlInterceptor both in the BrowserMediaPlayerManager and the
MediaPlayerRenderer without any problems. This change adds the extra
registration

BUG=636588

Committed: https://crrev.com/20038e2480c5e8fd98615cc63a48db56b6da3eab
Cr-Commit-Position: refs/heads/master@{#432334}
==========

[commit-bot: I haz the power, 2016-11-16 01:28:47]

Patchset 1 (id:??) landed as
https://crrev.com/20038e2480c5e8fd98615cc63a48db56b6da3eab
Cr-Commit-Position: refs/heads/master@{#432334}