Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2503153002:
Enable MediaPlayerRenderer by default (Closed)
|
Created:
4 years, 1 month ago by tguilbert Modified:
4 years, 1 month ago Reviewers:
DaleCurtis CC:
chromium-reviews, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable MediaPlayerRenderer by default
This changes disables WebMediaPlayerAndroid and enables
the MediaPlayerRenderer instead. This allows us to maintain
support for HLS playback, while phasing out WMPA.
BUG=619729
TEST=Manual verification of various HLS example streams.
Committed: https://crrev.com/5aecbd632d5640b67c3b4746b0a53b173bc42a31
Cr-Commit-Position: refs/heads/master@{#432765}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 28 (20 generated)
The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tguilbert@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enable MediaPlayerRender by default BUG=619729 ========== to ========== Enable MediaPlayerRenderer by default This changes disables WebMediaPlayerAndroid and enables the MediaPlayerRenderer instead. This allows us to maintain support for HLS playback, while phasing out WMPA. BUG=619729 TEST=Manual verification of various HLS example streams. ==========
tguilbert@chromium.org changed reviewers: + dalecurtis@google.com
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tguilbert@chromium.org changed reviewers: + dalecurtis@chromium.org - dalecurtis@google.com
PTAL (using the proper account this time -_-)
lgtm
The CQ bit was checked by tguilbert@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by tguilbert@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable MediaPlayerRenderer by default This changes disables WebMediaPlayerAndroid and enables the MediaPlayerRenderer instead. This allows us to maintain support for HLS playback, while phasing out WMPA. BUG=619729 TEST=Manual verification of various HLS example streams. ========== to ========== Enable MediaPlayerRenderer by default This changes disables WebMediaPlayerAndroid and enables the MediaPlayerRenderer instead. This allows us to maintain support for HLS playback, while phasing out WMPA. BUG=619729 TEST=Manual verification of various HLS example streams. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable MediaPlayerRenderer by default This changes disables WebMediaPlayerAndroid and enables the MediaPlayerRenderer instead. This allows us to maintain support for HLS playback, while phasing out WMPA. BUG=619729 TEST=Manual verification of various HLS example streams. ========== to ========== Enable MediaPlayerRenderer by default This changes disables WebMediaPlayerAndroid and enables the MediaPlayerRenderer instead. This allows us to maintain support for HLS playback, while phasing out WMPA. BUG=619729 TEST=Manual verification of various HLS example streams. Committed: https://crrev.com/5aecbd632d5640b67c3b4746b0a53b173bc42a31 Cr-Commit-Position: refs/heads/master@{#432765} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5aecbd632d5640b67c3b4746b0a53b173bc42a31 Cr-Commit-Position: refs/heads/master@{#432765} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
