Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2503763003: Reland of [turbofan] Fix deoptimization of boolean bit constants. (patchset #1 id:1 of https://code… (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [turbofan] Fix deoptimization of boolean bit constants. (patchset #1 id:1 of https://codereview.chromium.org/2495243002) This reverts commit 1c9528c4c44e0a1bce2fae9d4e2363420746744d. BUG=chromium:664490 Committed: https://crrev.com/7ae7e843404b1ec3fd8b6cbf12a50ed93da30b59 Cr-Commit-Position: refs/heads/master@{#40994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M src/compiler/code-generator.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-664490.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Jarin
Could you take a look, please?
4 years, 1 month ago (2016-11-15 13:29:40 UTC) #4
Benedikt Meurer
lgtm
4 years, 1 month ago (2016-11-15 13:32:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503763003/1
4 years, 1 month ago (2016-11-15 13:33:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 13:55:15 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:34:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ae7e843404b1ec3fd8b6cbf12a50ed93da30b59
Cr-Commit-Position: refs/heads/master@{#40994}

Powered by Google App Engine
This is Rietveld 408576698