Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2495243002: [turbofan] Fix deoptimization of boolean bit constants. (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix deoptimization of boolean bit constants. BUG=chromium:664490 Committed: https://crrev.com/297a969aada4b575a207219a77838b352b18f677 Cr-Commit-Position: refs/heads/master@{#40951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M src/compiler/code-generator.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-664490.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Jarin
Could you take a look, please?
4 years, 1 month ago (2016-11-14 09:05:59 UTC) #4
Benedikt Meurer
lgtm
4 years, 1 month ago (2016-11-14 09:06:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2495243002/1
4 years, 1 month ago (2016-11-14 09:09:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 09:30:13 UTC) #9
Jarin
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2502613002/ by jarin@chromium.org. ...
4 years, 1 month ago (2016-11-14 12:10:12 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:31:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/297a969aada4b575a207219a77838b352b18f677
Cr-Commit-Position: refs/heads/master@{#40951}

Powered by Google App Engine
This is Rietveld 408576698