Fixed collected cookies view info bar visibility

chrome/browser/ui/views/collected_cookies_views.cc

Index: chrome/browser/ui/views/collected_cookies_views.cc
diff --git a/chrome/browser/ui/views/collected_cookies_views.cc b/chrome/browser/ui/views/collected_cookies_views.cc
index 74979c5507c582d41fdcea49cde97ddbaeaa7143..6ff780fddb95e390ab662db8f07a1edb5bf550d8 100644
--- a/chrome/browser/ui/views/collected_cookies_views.cc
+++ b/chrome/browser/ui/views/collected_cookies_views.cc
@@ -150,9 +150,11 @@ class InfobarView : public views::View {
 
   // views::View overrides.
   gfx::Size GetPreferredSize() const override {
-    if (!visible())
-      return gfx::Size();
-
+    // Removed the "if (!visible())" check in order to always return the
+    // preferred size. This ensures that the layout manager always reserves
+    // space within the view so it can be displayed. Otherwise, the layout
+    // manager doesn't provide a space for it to display and the size of the
+    // containing dialog isn't large enough for it to ever become visible.

[Peter Kasting, 2016/11/29 20:51:17]

This comment makes sense in the context of this patch, but will be confusing in
the future for people without the context of either the bug or the old code. 
What about something like this:

Always return the preferred size, even if not currently visible.  This will
cause the layout manager to reserve space for this infobar so it can easily be
made visible later if necessary.  Otherwise, toggling the visibility of the
infobar would require resizing the entire dialog larger to make room, which is
undesirable from both a UX and a technical perspective.

     // Add space around the banner.
     gfx::Size size(content_->GetPreferredSize());
     size.Enlarge(0, 2 * views::kRelatedControlVerticalSpacing);