Fixed collected cookies view info bar visibility

chrome/browser/ui/views/collected_cookies_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/collected_cookies_views.h"
 
 #include "base/macros.h"
 #include "chrome/browser/browsing_data/browsing_data_appcache_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_channel_id_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_cookie_helper.h"
@@ skipping 132 matching lines @@
                              kInfobarHorizontalPadding,
                              kInfobarVerticalPadding,
                              views::kRelatedControlSmallHorizontalSpacing));
     content_->AddChildView(info_image_);
     content_->AddChildView(label_);
     UpdateVisibility(false, CONTENT_SETTING_BLOCK, base::string16());
   }
 
   // views::View overrides.
   gfx::Size GetPreferredSize() const override {
-    if (!visible())
-      return gfx::Size();
-
+    // Removed the "if (!visible())" check in order to always return the
+    // preferred size. This ensures that the layout manager always reserves
+    // space within the view so it can be displayed. Otherwise, the layout
+    // manager doesn't provide a space for it to display and the size of the
+    // containing dialog isn't large enough for it to ever become visible.

[Peter Kasting, 2016/11/29 20:51:17]

This comment makes sense in the context of this patch, but will be confusing in
the future for people without the context of either the bug or the old code. 
What about something like this:

Always return the preferred size, even if not currently visible.  This will
cause the layout manager to reserve space for this infobar so it can easily be
made visible later if necessary.  Otherwise, toggling the visibility of the
infobar would require resizing the entire dialog larger to make room, which is
undesirable from both a UX and a technical perspective.

     // Add space around the banner.
     gfx::Size size(content_->GetPreferredSize());
     size.Enlarge(0, 2 * views::kRelatedControlVerticalSpacing);
     return size;
   }
 
   void Layout() override {
     content_->SetBounds(
         0, views::kRelatedControlVerticalSpacing,
         width(), height() - views::kRelatedControlVerticalSpacing);
@@ skipping 395 matching lines @@
 ///////////////////////////////////////////////////////////////////////////////
 // CollectedCookiesViews, content::NotificationObserver implementation:
 
 void CollectedCookiesViews::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   DCHECK_EQ(chrome::NOTIFICATION_COLLECTED_COOKIES_SHOWN, type);
   GetWidget()->Close();
 }