Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2503613002: MD History: focus REMOVE button by default in multi-delete dialog (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org, pink (ping after 24hrs)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: focus REMOVE button by default in multi-delete dialog R=tsergeant@chromium.org BUG=664777 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ae7af053da762dc6d0aed3a3a2cd7c7bb084b253 Cr-Commit-Position: refs/heads/master@{#432039}

Patch Set 1 #

Patch Set 2 : revert downloads #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/list_container.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Dan Beam
4 years, 1 month ago (2016-11-14 20:33:28 UTC) #3
tsergeant
lgtm If you're intending to merge this back, then you may want to remove the ...
4 years, 1 month ago (2016-11-14 21:44:39 UTC) #8
Dan Beam
On 2016/11/14 21:44:39, tsergeant wrote: > lgtm > > If you're intending to merge this ...
4 years, 1 month ago (2016-11-14 21:50:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503613002/20001
4 years, 1 month ago (2016-11-15 00:17:12 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 01:00:33 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 01:04:52 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae7af053da762dc6d0aed3a3a2cd7c7bb084b253
Cr-Commit-Position: refs/heads/master@{#432039}

Powered by Google App Engine
This is Rietveld 408576698