Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2500153002: MD Downloads: pick up vulcanize changes from dependent files (i.e. util.js) (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: pick up vulcanize changes from dependent files (i.e. util.js) R=tsergeant@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/53096fffadf7157934a227797e47e6226f7805c6 Cr-Commit-Position: refs/heads/master@{#431994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Dan Beam
4 years, 1 month ago (2016-11-14 21:50:19 UTC) #2
tsergeant
lgtm
4 years, 1 month ago (2016-11-14 21:54:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500153002/1
4 years, 1 month ago (2016-11-14 22:14:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 23:58:13 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 00:02:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53096fffadf7157934a227797e47e6226f7805c6
Cr-Commit-Position: refs/heads/master@{#431994}

Powered by Google App Engine
This is Rietveld 408576698