support 3d texture sub-source uploads from ImageData

support 3d texture sub-source uploads from ImageData

Tested in https://github.com/KhronosGroup/WebGL/pull/2141

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/37ca6299bbad917d6b0b2d52f5bee18618d95b47
Cr-Commit-Position: refs/heads/master@{#432108}

[Kai Ninomiya, 2016-11-11 18:47:34]

Description was changed from

==========
support 3d texture sub-source uploads from ImageData

BUG=639145
==========

to

==========
support 3d texture sub-source uploads from ImageData

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2016-11-11 18:52:13]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 18:52:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-11-11 18:52:37]

The CQ bit was unchecked by kainino@chromium.org

[Kai Ninomiya, 2016-11-11 19:10:21]

kainino@chromium.org changed reviewers:
+ kbr@chromium.org

[Kai Ninomiya, 2016-11-11 19:10:22]

kbr: PTAL, but I can't dry run this yet because my WebGL conformance PR will
have to be merged and then rolled.

[Kai Ninomiya, 2016-11-14 19:45:04]

Description was changed from

==========
support 3d texture sub-source uploads from ImageData

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
support 3d texture sub-source uploads from ImageData

Tested in https://github.com/KhronosGroup/WebGL/pull/2141

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-14 20:12:30]

Great work. Looks almost perfect. One small issue.

https://codereview.chromium.org/2500433003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2500433003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4752: }
This should only be used for the 3D upload path. To make this clearer, as in
WebGLRenderingContextBase::texImageImpl, please put this in the arm handling the
3D texture functions.

https://codereview.chromium.org/2500433003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4760:
uploadHeight, format, type, bytes);
The 2D upload path shouldn't take into consideration the GL_UNPACK_IMAGE_HEIGHT;
this one should reference the adjustedSourceImageRect's width and height.

[Kai Ninomiya, 2016-11-14 21:21:35]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[Kai Ninomiya, 2016-11-14 21:23:17]

Done. Rolling WebGL conformance and dry running.

https://codereview.chromium.org/2500433003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2500433003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4752: }
On 2016/11/14 20:12:30, Ken Russell wrote:
> This should only be used for the 3D upload path. To make this clearer, as in
> WebGLRenderingContextBase::texImageImpl, please put this in the arm handling
the
> 3D texture functions.

Done.

https://codereview.chromium.org/2500433003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4760:
uploadHeight, format, type, bytes);
On 2016/11/14 20:12:30, Ken Russell wrote:
> The 2D upload path shouldn't take into consideration the
GL_UNPACK_IMAGE_HEIGHT;
> this one should reference the adjustedSourceImageRect's width and height.

Done.

[commit-bot: I haz the power, 2016-11-14 21:23:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-11-14 21:27:38]

LGTM modulo one tiny thing.

https://codereview.chromium.org/2500433003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2500433003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4748:
GLint uploadHeight = adjustedSourceImageRect.height();
Could you please just put these two definitions into the "else" branch for the
3D case? See texImageImpl.

[Kai Ninomiya, 2016-11-14 21:39:44]

Description was changed from

==========
support 3d texture sub-source uploads from ImageData

Tested in https://github.com/KhronosGroup/WebGL/pull/2141

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
support 3d texture sub-source uploads from ImageData

Tested in https://github.com/KhronosGroup/WebGL/pull/2141

// upload remaining tiny changes before committing
COMMIT=false
BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-14 22:21:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 22:21:57]

Dry run: Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Kai Ninomiya, 2016-11-15 00:04:06]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 00:05:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-11-15 01:26:16]

Description was changed from

==========
support 3d texture sub-source uploads from ImageData

Tested in https://github.com/KhronosGroup/WebGL/pull/2141

// upload remaining tiny changes before committing
COMMIT=false
BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
support 3d texture sub-source uploads from ImageData

Tested in https://github.com/KhronosGroup/WebGL/pull/2141

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-15 03:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 03:12:15]

Dry run: This issue passed the CQ dry run.

[Kai Ninomiya, 2016-11-15 05:00:59]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2016-11-15 05:00:59]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2500433003/#ps60001
(title: "address comment + rebase")

[commit-bot: I haz the power, 2016-11-15 05:01:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 05:08:27]

Description was changed from

==========
support 3d texture sub-source uploads from ImageData

Tested in https://github.com/KhronosGroup/WebGL/pull/2141

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
support 3d texture sub-source uploads from ImageData

Tested in https://github.com/KhronosGroup/WebGL/pull/2141

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-15 05:08:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-15 05:14:14]

Description was changed from

==========
support 3d texture sub-source uploads from ImageData

Tested in https://github.com/KhronosGroup/WebGL/pull/2141

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
support 3d texture sub-source uploads from ImageData

Tested in https://github.com/KhronosGroup/WebGL/pull/2141

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/37ca6299bbad917d6b0b2d52f5bee18618d95b47
Cr-Commit-Position: refs/heads/master@{#432108}
==========

[commit-bot: I haz the power, 2016-11-15 05:14:15]

Patchset 4 (id:??) landed as
https://crrev.com/37ca6299bbad917d6b0b2d52f5bee18618d95b47
Cr-Commit-Position: refs/heads/master@{#432108}