Issue 2503483002: [ObjC ARC] Converts ios/chrome/common to ARC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2503483002: [ObjC ARC] Converts ios/chrome/common to ARC (Closed)

Created:
4 years, 1 month ago by stkhapugin

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[ObjC ARC] Converts ios/chrome/common to ARC Notable Changes: none BUG=659147

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -8 lines)			Patch
M	ios/chrome/common/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ios/chrome/common/channel_info.mm	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ios/chrome/common/material_timing.mm	View	3 chunks	+20 lines, -8 lines	0 comments	Download
M	ios/chrome/common/string_util.mm	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 4 (4 generated)

stkhapugin

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

4 years, 1 month ago (2016-11-14 14:55:24 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503483002/1

4 years, 1 month ago (2016-11-14 14:55:42 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 1 month ago (2016-11-14 16:15:10 UTC) #3

commit-bot: I haz the power

4 years, 1 month ago (2016-11-14 16:15:11 UTC) #4

Dry run: This issue passed the CQ dry run.