Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2502663002: [ObjC ARC] Converts ios/chrome/common/app_group to ARC (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/common/app_group to ARC Notable Changes: none BUG=659147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M ios/chrome/common/app_group/BUILD.gn View 3 chunks +6 lines, -0 lines 0 comments Download
M ios/chrome/common/app_group/app_group_constants.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/common/app_group/app_group_metrics.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/common/app_group/app_group_metrics_client.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/common/app_group/app_group_metrics_mainapp.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 1 (0 generated)
stkhapugin
4 years, 1 month ago (2016-11-15 13:21:29 UTC) #1
This fails downstream tests.

Powered by Google App Engine
This is Rietveld 408576698